fix(cinder): simplify NetApp NVMe driver to minimal override - #2238
Merged
Conversation
cardoe
reviewed
Aug 24, 2026
cardoe
left a comment
cardoe
left a comment
Contributor
There was a problem hiding this comment.
If the purpose is to just override the NVMe subsystem of the stock driver then we should do that instead of hacking this to not update the original host. This will fail in other wise
Contributor
|
do we really need dynamic_netapp_driver for the shared SVM design ? I think Cinder can use normal configured backends. We only need a small wrapper around the default NetApp NVMe driver unless we fix Novaor ironic to send nqn directly if "initiator" in connector and "nqn" not in connector:
connector["nqn"] = connector["initiator"] |
khackworth
force-pushed
the
netapp_create_volume
branch
2 times, most recently
from
August 25, 2026 19:22
e0080ba to
453e776
Compare
khackworth
enabled auto-merge
August 25, 2026 19:23
nidzrai
reviewed
Aug 26, 2026
khackworth
force-pushed
the
netapp_create_volume
branch
2 times, most recently
from
August 26, 2026 11:51
386d84e to
563724d
Compare
nidzrai
reviewed
Aug 26, 2026
khackworth
force-pushed
the
netapp_create_volume
branch
2 times, most recently
from
August 26, 2026 12:17
0c06e48 to
15e601b
Compare
- Override only _map_namespace() for custom subsystem naming
- Subsystem naming: {svm}-{ostype} (e.g., rax-prod-dfw3-vmware)
- Upstream handles namespace creation, ostype, and 512B blocks for VMware
Requires multiple backend configs per SVM (one for vmware, one for linux)
khackworth
force-pushed
the
netapp_create_volume
branch
from
August 26, 2026 15:50
15e601b to
1449f71
Compare
nidzrai
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing most of the custom driver, leaving the nqn -> initiator mapping