Soften ok = setopts nopush matches in osiris_replica_reader - #228
Merged
Conversation
Setting TCP_NOPUSH can fail with EINVAL on an already-broken replica->writer socket (e.g. writer node restarting under load, observed on macOS). The hard ok = match crash-looped the replica reader, keeping streams below quorum+1 and hanging await_online_quorum_plus_one during rolling restarts. nopush is only a latency hint, so ignore setopts failures here as the error branch already does, and let the reader tear down/reconnect normally. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting TCP_NOPUSH can fail with EINVAL on an already-broken replica->writer socket (e.g. writer node restarting under load, observed on macOS). The hard ok = match crash-looped the replica reader, keeping streams below quorum+1 and hanging await_online_quorum_plus_one during rolling restarts. nopush is only a latency hint, so ignore setopts failures here as the error branch already does, and let the reader tear down/reconnect normally.