Initialise first offset - #223
Draft
dcorbacho wants to merge 1 commit into
Draft
Conversation
dcorbacho
force-pushed
the
initialise-first-offset
branch
from
June 17, 2026 13:50
1e85a25 to
58bddce
Compare
kjnilsson
approved these changes
Jun 17, 2026
There was a problem hiding this comment.
Pull request overview
This PR aims to ensure the log’s first_offset counter reflects a non-zero starting offset (e.g., after retry_accept_chunk resets) so downstream calculations that rely on (last_offset + 1 - first_offset) remain accurate.
Changes:
- Initialize
?C_FIRST_OFFSETtoDefaultNextOffsetwhen the log directory has no existing segments (first_and_last_seginfos/1returnsnone). - Add inline documentation explaining why this initialization is needed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+576
to
+580
| %% When the log starts at a non-zero offset (e.g. after a | ||
| %% retry_accept_chunk reset), reflect that in the first_offset counter | ||
| %% so that message-count calculations (last_offset + 1 - first_offset) | ||
| %% remain correct. | ||
| counters:put(Cnt, ?C_FIRST_OFFSET, DefaultNextOffset), |
| %% retry_accept_chunk reset), reflect that in the first_offset counter | ||
| %% so that message-count calculations (last_offset + 1 - first_offset) | ||
| %% remain correct. | ||
| counters:put(Cnt, ?C_FIRST_OFFSET, DefaultNextOffset), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the log starts at a non-zero offset (e.g. after a retry_accept_chunk reset), reflect that in the first_offset counter so that message-count calculations (last_offset + 1 - first_offset) remain correct.