Restore speaker review samples from retained meeting audio - #1730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A speaker-naming failure deletes temporary clips, but Speakers review only looked for saved profile clips. A meeting with retained audio could therefore still show disabled sample buttons after failure. This adds playable recovery for those already-saved meetings.
The 1.1.55 stable-ID resolver also had a confirmed defect: decoding a strict 2 KB UTF-8 prefix could fail when the read split a multibyte character, even with the correct ID earlier in the file. #1686 already fixed that resolver, and subsequent changes on
mainrestored pending-review retranscription and durable failure retries. The sanitized customer evidence cannot establish the exact original byte boundary. This PR preserves those fixes and covers the real save-to-finalization path instead of duplicating them.Fixes #1681.
Product Impact
What changed
How I checked it
bash build-deps.sh --forcebash build.sh --no-open— isolated launch smoke and bundle performance gate passedbash run-tests.sh— 12,794 assertions passedbash run-integration-smoke.shTRANSCRIPTED_DISABLE_FILE_LOGGER=1 swift test— 1,085 tests, 13 opt-in skips, zero failuresorigin/main(7c483f8c): no findings; no findings rejected. The additional beyond-EOF playback check passed on a real muted WAV.Native UI click/screenshot verification is incomplete because the automation host lacks Accessibility/Event Posting permission. See review evidence. Synthetic tests do not reproduce the customer's recording or prove its diarization/audio quality.
Risk Review
Agent handoff
COORD_DONE: GREEN | PR linked to #1681 | retained-audio speaker samples and regression coverage | no GitHub cleanup | human review; native UI click proof remains incomplete | mapped checks passed | lanes used: Codex=implementation plus independent Astra review; Claude=skipped, risk covered by independent review; Local=skipped, bounded Swift work; Windows=skipped, macOS playback task | review the draft PR