Fix Homebrew macOS dependency deprecation warning - #1729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fixes #1707, reported by @mustafakapasi. Tapping or loading Transcripted emits Homebrew's deprecation warning for the string comparison form of
depends_on macos:.Product Impact
What changed
This is the cask users actually install: the README and issue reproduction use
brew tap r3dbars/transcripted https://github.com/r3dbars/transcripted. Homebrew names the local checkouthomebrew-transcripted, but the explicit tap URL points to this repository. No separater3dbars/homebrew-transcriptedrepository was found.The Homebrew Cask Cookbook defines the bare symbol as a minimum OS release. The README,
Info.plist(26.0), and package platform all already require macOS 26. Both release cask writers change only version/checksum, so they preserve this fix.How I checked it
ruby -c Casks/transcripted.rb: passed.git diff --check: passed.Agent preflight: passed; mapped release checks are recorded below.
Independent Codex review of the complete diff against
origin/mainat7c483f8c5e4c792f79eec6eef415967446dc14db: PASS, no findings or rejected findings. Reviewed tap ownership, OS semantics, release writers, and unchanged metadata.Temporary Homebrew checkout (
Homebrew/brew@8f87b3091d7dde4d51adb492e4f0a1fd4f8b4bdf): reproduced the exact warning with the base cask; the fixed cask no longer emits it.brew info --json=v2 --caskresolves identical dependencies before/after, includingmacos: {">=": ["26"]}. No app installation was performed.Focused release metadata suite: 28/28 passed. Updated its existing assertion, which required the deprecated syntax.
The temporary Homebrew version also warns about the existing
url verified:parameter; that separate warning is unchanged and outside Warning: Calling string comparion format for 'depends_on macos' is deprecated #1707.bash build-deps.sh --force: passed.bash scripts/ops/transcripted-qa-bench.sh --mode full: PASS, 15/15 checks, including app build, all 12,751 fast tests, integration/core tests, and release-health fixtures.SKIP_NOTARIZATION=1 REGISTER_SENTRY_RELEASE=0 bash build-beta.sh '' Justin: passed; local packaging only, with no notarization or publication.Risk Review
The cask declaration and its existing release-metadata test expectation change. Version, checksum, download URL, architecture, Sparkle/appcast, and app source are unchanged. No new app release is needed for this tap syntax correction. The fix reaches tap users after merge and a tap refresh; this draft PR does not publish it.
Notes
Please review; do not merge automatically. No issue closure, release publication, or other worktree changes are part of this PR.
Maestro lanes: Codex implementation and independent review used. Claude, Local, and Windows skipped for this small cask syntax change;
maestro-delegateis unavailable on the validation Mac.