Conversation
thomasp85
requested changes
Sep 17, 2026
Member
|
The CI is failing because you need to regenerate the documentation ( |
Author
|
Member
|
Fix in #839 pending @gaborcsardi approval. |
gaborcsardi
reviewed
Sep 24, 2026
| #' bar of the calling function. See more at 'The current progress bar' | ||
| #' below. | ||
| #' @param quiet if `TRUE` suppresses output from this function. Defaults to the `cli.disable_progress` option, or | ||
| #' `TRUE` if unset. |
Member
There was a problem hiding this comment.
The docs still say 'TRUE' or am I missing something here?
gaborcsardi
reviewed
Sep 24, 2026
| clienv$progress[[id]] <- bar | ||
| if (current) { | ||
| if (!is.null(clienv$progress_ids[[envkey]])) { | ||
| if (!is.null(clienv$progress_ids[[envkey]]) && !quiet) { |
Member
There was a problem hiding this comment.
This does not seem correct to me. If we are creating a new progress bar, then that should be the current progress bar, whether it is quiet or not.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #645 by adding an argument
quietto suppress progress bar when quiet = FALSE.