hash: validate raw helper size arguments - #836
Merged
Merged
Conversation
Fixes r-lib#834. Assisted-by: OpenAI Codex (GPT-5)
Contributor
Author
|
Status note: the only failing check, format-suggest, fails before formatting because the pull_request_target workflow refuses to check out fork code for security. This is a workflow authorization boundary, not a reported formatting failure in the patch. No code change is needed from the contributor unless maintainers prefer a different trusted validation path. |
Keep both the raw hash validation entry and the upstream ansi_strwrap entry. Validation: the PR's hash implementation and regression tests are unchanged; git diff --check against upstream passes. R is unavailable in this environment, so R tests were not rerun for this synchronization. Prepared with OpenAI Codex assistance.
gaborcsardi
requested changes
Sep 26, 2026
Document that the raw helper ranges match hash_emoji() and hash_animal(), and that the upper bounds keep the shared conversions within exact double-precision integer arithmetic. This is a comment-only follow-up to the review; executable code and regression tests are unchanged. Verified both upper bounds against the table sizes documented by the package and checked the diff for whitespace errors. Prepared with OpenAI Codex assistance.
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hash_raw_emoji()andhash_raw_animal()Fixes #834.
Verification
testthat::test_local(filter = "hash", reporter = "silent")- 53 passed, 0 failures, 0 errors, 0 warnings, 0 skipsair format R/hash.R tests/testthat/test-hash.RR CMD build --no-manualR CMD check --no-manualon the source tarball -Status: OKAI assistance
OpenAI Codex (GPT-5) assisted with implementation, tests, and verification.