Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the dummy cluster manifests (both the “src” and “tests” template trees) to better manage HelmRelease CRDs/cleanup behavior, rationalizes Kustomization paths (dropping the ci/ segment), and updates the template CI workflow to use a newer Flux version and the new cluster path layout.
Changes:
- Add HelmRelease install/upgrade settings (
crds: CreateReplace,cleanupOnFail: true) via patches in dummy cluster kustomizations. - Rework dummy “tests” cluster layout: fix Kustomization
path:values, add missingkustomization.yamlaggregators, and introduce a Flux namespace Kustomization. - Update the template GitHub Actions workflow to Flux v2.8.7 and to reconcile from
tests/clusters/${{ matrix.cluster }}.
Reviewed changes
Copilot reviewed 24 out of 27 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/clusters/dummy/kustomization.yaml | Adds HelmRelease install/upgrade patch defaults for the dummy test cluster. |
| src/tests/clusters/dummy/infrastructure/metrics/metrics.yaml | Updates Flux Kustomization path to the new tests/clusters/dummy/... layout. |
| src/tests/clusters/dummy/infrastructure/metrics/kustomize/metrics-namespace/metrics-namespace.yaml | Updates nested Kustomization path to the new layout. |
| src/tests/clusters/dummy/infrastructure/metrics/kustomize/metrics-namespace/kustomize/kustomization.yaml | Fixes relative resource path to the main src/clusters/... manifests. |
| src/tests/clusters/dummy/infrastructure/metrics/kustomize/metrics-helm/metrics-helm.yaml | Updates nested Kustomization path to the new layout. |
| src/tests/clusters/dummy/infrastructure/metrics/kustomize/metrics-helm/kustomize/kustomization.yaml | Fixes relative resource path to the main src/clusters/... manifests. |
| src/tests/clusters/dummy/infrastructure/metrics/kustomize/kustomization.yaml | Adds an aggregator kustomization to compose metrics namespace + helm components. |
| src/tests/clusters/dummy/infrastructure/kustomization.yaml | Adds Flux infra resource and wires it into dummy infrastructure. |
| src/tests/clusters/dummy/infrastructure/flux/kustomize/kustomization.yaml | Adds an aggregator kustomization for Flux-related infra components. |
| src/tests/clusters/dummy/infrastructure/flux/kustomize/flux-namespace/kustomize/kustomization.yaml | Adds overlay kustomization that references the main src/clusters/... namespace setup. |
| src/tests/clusters/dummy/infrastructure/flux/kustomize/flux-namespace/flux-namespace.yaml | Introduces Flux Kustomization to apply the Flux namespace overlay for tests. |
| src/tests/clusters/dummy/infrastructure/flux/flux.yaml | Adds a Flux “umbrella” Kustomization that targets flux-system for nested items. |
| src/tests/clusters/dummy/apps/podinfo/podinfo.yaml | Updates Flux Kustomization path to the new tests/clusters/dummy/... layout. |
| src/tests/clusters/dummy/apps/podinfo/kustomize/podinfo-namespace/podinfo-namespace.yaml | Updates nested Kustomization path to the new layout. |
| src/tests/clusters/dummy/apps/podinfo/kustomize/podinfo-namespace/kustomize/kustomization.yaml | Fixes relative resource path to the main src/clusters/... manifests. |
| src/tests/clusters/dummy/apps/podinfo/kustomize/podinfo-helm/podinfo-helm.yaml | Updates nested Kustomization path to the new layout. |
| src/tests/clusters/dummy/apps/podinfo/kustomize/podinfo-helm/kustomize/kustomization.yaml | Fixes relative resource path to the main src/clusters/... manifests. |
| src/tests/clusters/dummy/apps/podinfo/kustomize/kustomization.yaml | Adds an aggregator kustomization to compose podinfo namespace + helm components. |
| src/tests/clusters/dummy/apps/kustomization.yaml | Adds an apps-layer kustomization that applies common labeling patches. |
| src/src/clusters/dummy/kustomization.yaml | Adds HelmRelease install/upgrade patch defaults for the main dummy cluster. |
| src/src/clusters/dummy/infrastructure/kustomization.yaml | Adds Flux infra resource and wires it into dummy infrastructure. |
| src/src/clusters/dummy/infrastructure/flux/kustomize/kustomization.yaml | Adds an aggregator kustomization for Flux-related infra components. |
| src/src/clusters/dummy/infrastructure/flux/kustomize/flux-namespace/kustomize/resources/namespace.yaml | Adds the flux-system Namespace manifest. |
| src/src/clusters/dummy/infrastructure/flux/kustomize/flux-namespace/kustomize/kustomization.yaml | Adds kustomization to include the Namespace resource. |
| src/src/clusters/dummy/infrastructure/flux/kustomize/flux-namespace/flux-namespace.yaml | Introduces Flux Kustomization to apply the Flux namespace manifests. |
| src/src/clusters/dummy/infrastructure/flux/flux.yaml | Adds a Flux “umbrella” Kustomization that targets flux-system for nested items. |
| src/{% if true %}.github{% endif %}/workflows/test.yaml | Updates Flux action/CLI version and points test reconciliation at tests/clusters/${cluster}. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.