Skip to content

Fix -Wmaybe-uninitialized warning in js_binary_logic_slow #1530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sdrsdr wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −0
Open

Fix -Wmaybe-uninitialized warning in js_binary_logic_slow #1530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions quickjs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15324,6 +15324,11 @@ static no_inline __exception int js_binary_logic_slow(JSContext *ctx,
JSBigInt *p1, *p2, *r;
JSBigIntBuf buf1, buf2;
slow_big_int:
/* buf2 is zero-initialized here (after the label, so it also runs on
the goto slow_big_int paths) to silence a -Wmaybe-uninitialized
false positive: GCC cannot prove buf2 is initialized through the
inlined js_bigint_get_si_sat() -> js_bigint_sign() read below. */
memset(&buf2, 0, sizeof(buf2));
if (JS_VALUE_GET_TAG(op1) == JS_TAG_SHORT_BIG_INT)
p1 = js_bigint_set_short(&buf1, op1);
else
Expand Down
Loading