Disable standalone executable support under WASM / Emscripten#1528
Merged
Conversation
bnoordhuis
approved these changes
Jun 9, 2026
bnoordhuis
left a comment
Contributor
There was a problem hiding this comment.
Instead of commenting out big blocks of code, it's more robust to do something like:
#if defined(EMSCRIPTEN) || defined(__wasi__)
#define emscripten_or_wasi 1
#else
#define emscripten_or_wasi 0
#endifAnd then instead of ifdef'ing out code, like this:
#if !defined(EMSCRIPTEN) && !defined(__wasi__)
do_the_thing();
#endifYou do:
if (!emscripten_or_wasi) {
do_the_thing();
}That way all code is always compiler-checked.
Comment on lines
+693
to
+696
| } else if (expr) { | ||
| #else | ||
| if (expr) { | ||
| #endif |
Contributor
There was a problem hiding this comment.
Maybe this instead?
Suggested change
| } else if (expr) { | |
| #else | |
| if (expr) { | |
| #endif | |
| } | |
| #endif | |
| if (!standalone && expr) { |
Arguably mildly easier to read.
54244ea to
37a7dc2
Compare
37a7dc2 to
3b1c108
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1527