Fix socket address failover before successful logon - #1324
Open
elliotoakley wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1324 +/- ##
============================================
+ Coverage 70.81% 70.85% +0.03%
- Complexity 2268 2274 +6
============================================
Files 161 161
Lines 9077 9085 +8
Branches 1192 1193 +1
============================================
+ Hits 6428 6437 +9
+ Misses 2195 2193 -2
- Partials 454 455 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the round-robin socket address index was reset immediately after a successful TCP connection. If an endpoint accepted the connection but closed it before completing the FIX Logon, the initiator repeatedly retried the first address instead of failing over to the next configured address.
The index is now reset only after SessionStateListener.onLogon() is invoked. A volatile flag transfers the reset request to the scheduled ConnectTask thread.
Tests verify that the initiator:
Fixes #1260