Skip to content

Ignore deprecated FIX values in generated outputs - #97

Draft
chrjohn with Copilot wants to merge 16 commits into
masterfrom
copilot/update-transformation-ignore-deprecated-values
Draft

chrjohn with Copilot wants to merge 16 commits into
masterfrom
copilot/update-transformation-ignore-deprecated-values

Conversation

Copilot AI commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

FIX.Latest transformations must exclude values deprecated in prior FIX versions or in an earlier FIX.Latest extension pack. Deprecated Orchestra codes currently leaked into generated data dictionaries and Java field classes.

  • Version-aware filtering

    • Added shared XSLT logic for FIX version and extension-pack deprecation rules.
    • Historical deprecations are excluded from FIX.Latest output.
    • FIX.Latest deprecations are excluded when deprecatedEP is at or before the repository EP.
  • Generated artifacts

    • Filters deprecated code values in data dictionaries.
    • Filters deprecated constants in generated Java field classes.
    • Treats deprecated code sets as inactive.

For example, a code deprecated before the input EP is omitted:

<fixr:code name="Benchmark"
           value="6"
           deprecated="FIX.Latest"
           deprecatedEP="268"/>

Copilot AI and others added 10 commits August 9, 2026 17:57
Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
…tion

Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
…arations

Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
…-stylesheets

Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
….xml

Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Copilot AI and others added 2 commits September 3, 2026 14:50
Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
@chrjohn

chrjohn commented Sep 4, 2026

Copy link
Copy Markdown
Member

@copilot
We do not need the java11 module info file.
Do we still need orchestra.repository.version in the pom? I don't think so.

Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>

Copilot AI commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

@copilot
We do not need the java11 module info file.
Do we still need orchestra.repository.version in the pom? I don't think so.

Removed the unnecessary Java 11 module descriptor in commit $(git rev-parse --short HEAD). The orchestra.repository.version property is still required because it supplies the version for the repository dependency in the parent dependency management.

@chrjohn

chrjohn commented Sep 4, 2026

Copy link
Copy Markdown
Member

@copilot please remove all unneded dependencies from this project.

Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>

Copilot AI commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

@copilot please remove all unneded dependencies from this project.

Removed the obsolete JAXB dependencies and unused generator slf4j-simple runtime dependency in commit $(git rev-parse --short HEAD). The project builds successfully.

@copilot please remove all unneded dependencies from this project.

Dependency audit found the Orchestra repository dependency was also orphaned after the XSLT migration, so I removed it and its version property in commit $(git rev-parse --short HEAD). The project still builds successfully.

Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants