Support open-ended ranges, test ranges beyond the data - #118
Merged
Merged
Conversation
- readxl accepts ranges with the row number omitted on either end (fixes #70): "Sheet1!A3:A" reads from row 3 to the last used row of the sheet, "Sheet1!A:A" reads the whole column. Invalid forms like "A4:" or ":C" now give a clear error instead of an ArgumentError. - Add regression tests showing that ranges extending beyond the used part of a sheet come back as NA-filled cells for both backends (fixes #49 — the xlrd backend used to throw a PyError here). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works through the two remaining code-level issues:
readxlaccepts ranges with the row number omitted on either end —"Sheet1!A3:A"reads from row 3 to the last used row of the sheet,"Sheet1!A:A"reads the whole column. The missing end row is resolved against the sheet's used dimensions at read time; malformed forms like"A4:"or":C"now produce a clear error instead of anArgumentErrorfromparse.PyErrorhere; the native backends have handled it since v1.0.0 — now it's pinned by tests).All test items green locally for both backends, cross-backend parity included. Feature addition → suggest tagging as v1.1.0 (NEWS entry included; version bump left to you).
🤖 Generated with Claude Code