Pre-registration polish: compat fix, docs, defined-names tests - #116
Merged
Merged
Conversation
- Set the julia compat floor to 1.10: the declared 1.6 was unsatisfiable because XLSX 0.12 requires julia >= 1.10, so the 1.6-1.9 CI matrix jobs could never resolve. 1.10 (the current LTS) is the lowest floor the dependencies allow. Tighten LibXLS compat to "1" (0.1/0.2 were never registered). - Add docstrings for readxl, readxlsheet, readxlnames and readxlrange (fixes #26, fixes #37). - Add tests for readxlnames/readxlrange using a generated xlsx fixture with defined names, including the error for the xls backend (fixes #36). - Document defined names, close, and package limitations in the README; add v1.0.0 release notes. - Add tests for close and for the readxl_internal entry point that ExcelFiles relies on. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
LibXLS v1.0.0 declares julia >= 1.12; v1.0.1 relaxes that to 1.6, so it is the version that actually works across this package's supported julia range. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final polish before tagging/registering v1.0.0.
Julia compat: 1.10 (and why not 1.6)
The declared
julia = "1.6"floor was unsatisfiable: XLSX 0.12 hard-requires julia ≥ 1.10, so on julia 1.6–1.9 the resolver can never instantiate this package, and the corresponding CI matrix jobs fail structurally. 1.10 (the current LTS) is the lowest floor the dependencies allow, so this PR sets exactly that.LibXLS compat is set to
"1.0.1": v1.0.0 declares julia ≥ 1.12, while the now-registered v1.0.1 relaxes that to 1.6, making it the version that actually works across this package's supported julia range. With v1.0.1 in General, the full CI matrix here should be green.Docs and defined-names tests
readxl,readxlsheet,readxlnamesandreadxlrange(fixes Add inline docs for readxl and readxlsheet functions #26, fixes Add documentation for readxlnames and readxlrange #37).readxlnames/readxlrangeusing a generated xlsx fixture with defined names, including the clear error for the xls backend where libxls does not expose defined names (fixes Add tests for readxlnames and readxlrange #36).close, and package limitations (no formula text, no IO/buffer input); v1.0.0 release notes in NEWS.md.close(both backends) and for thereadxl_internalentry point that ExcelFiles relies on.Local coverage of
src/ExcelReaders.jlafter this PR: 94%+, with the remaining uncovered lines being function-definition-line counter artifacts and one dead-defensive error branch (the column blank-scan can never fail after the row blank-scan succeeded).After merging
Tag/register v1.0.0. The rewrite plus this PR also resolve #64, #60, #58 and #69, and supersede PRs #113, #114 and #100.
🤖 Generated with Claude Code