fix(smart_contracts): detect removed procedures in refresh script#174
Merged
sallymoc merged 2 commits intoJun 14, 2026
Merged
Conversation
The merge logic was additive-only for procedures: methods removed upstream were never deleted from smart_contracts.json, so the refresh workflow's checksum never changed and no PR was opened. Now a script-generated procedure (one with a sourceIdentifier) that is absent from a successfully-fetched source is pruned. Manual procedures (no sourceIdentifier) are preserved, and pruning is guarded on fetch success so a transient GitHub outage cannot wipe procedures. Also log new contracts, new procedures, and removed procedures so the GitHub Actions run log shows what changed. Applying the fix removes qRWA methods 5 (CreateAssetReleasePoll) and 6 (VoteAssetRelease), which were removed from qRWA.h.
Address code review: a 200 response with a truncated/garbage body parses to zero procedures, which would wipe a contract's entire procedure list. Only prune when the fresh fetch yielded at least one procedure (fresh_has_procs); individually removed procedures are still pruned. Also update the module docstring to describe the now-destructive merge behavior and the fetch-failure guard.
Contributor
|
🎉 This PR is included in version 1.27.1-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 1.27.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The refresh-smart-contracts workflow detects changes by comparing a checksum of
data/smart_contracts.jsonbefore/after runningscripts/update_smart_contracts.py. When methods were removed from a contract upstream (e.g. methods 5 & 6 in qRWA.h), the JSON never changed, the checksum matched, and no PR was opened.Root cause:
merge_contracts()was additive-only for procedures — it added/updated procedures but never deleted ones that disappeared from the source ("in case they were manually added").Fix
sourceIdentifier(i.e. it was script-generated) and is absent from a successfully-fetched source — it was removed upstream.sourceIdentifier(genuine manual additions).Data change
Running the script removes the two methods that were deleted from
qRWA.h:id 5—CreateAssetReleasePollid 6—VoteAssetRelease