Revert "Update mlflow version to 3.10.1 in requirements.txt" - #12
Open
MaheeGamage wants to merge 1 commit into
Open
Revert "Update mlflow version to 3.10.1 in requirements.txt"#12MaheeGamage wants to merge 1 commit into
MaheeGamage wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts the mlflow dependency version bump in the MLflow image back to a previously working version to avoid breaking changes that impact existing cluster configurations.
Changes:
- Downgrade
mlflowfrom3.10.1back to3.4.0in the MLflow image requirements.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| cryptography==44.0.3 # TODO: Check if this is needed | ||
| boto3==1.37.30 # Used because MinIO provides an S3-compatible API | ||
| mlflow==3.10.1 | ||
| mlflow==3.4.0 |
There was a problem hiding this comment.
Consider adding a short inline comment explaining why mlflow is pinned to 3.4.0 (e.g., 3.10.x introduces breaking changes with existing cluster configurations). The surrounding dependencies already include rationale comments, and capturing this here helps avoid accidental upgrades later.
Suggested change
| mlflow==3.4.0 | |
| mlflow==3.4.0 # Pinned because 3.10.x introduces breaking changes with existing cluster configurations |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #10
The mlflow version 3.10 have some breaking changes compared to version 3.4 which does not work with existing qluster configurrations. Either qluster or image need to be changed in order to make things work properly. So I am reverting this version increase change back to previous version which work properly with existing qluster configuration