Skip to content

Add on_error callback to CanDevice - #109

Merged
luismiguensfernandez merged 7 commits into
masterfrom
tl/add-on-error-cb
Aug 27, 2026
Merged

Add on_error callback to CanDevice#109
luismiguensfernandez merged 7 commits into
masterfrom
tl/add-on-error-cb

Conversation

@TiagoLourinho

@TiagoLourinho TiagoLourinho commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread test/python/test_socketcan.py Outdated
Comment thread src/main/CanVendorAnagate.cpp
Comment thread src/main/CanVendorSocketCan.cpp
Comment thread src/main/CanVendorSocketCan.cpp Outdated
Comment thread src/main/CanVendorSocketCan.cpp
Comment thread src/include/CanDeviceArguments.h Outdated
Comment thread src/include/CanDevice.h
@luismiguensfernandez

Copy link
Copy Markdown
Member

Hi,

Could you extends the tests:

  • receiver=None and only on_error set.
  • socketcan_systec forwarding of the error callback.
  • An error callback that requests close/open
  • A throwing C++ callback and a Python callback (the python callback should raise a random exception)

Comment thread src/main/CanVendorAnagate.cpp Outdated
@TiagoLourinho TiagoLourinho added this to the Ia@f#H660dLu milestone Aug 13, 2026
@TiagoLourinho TiagoLourinho removed this from the Ia@f#H660dLu milestone Aug 14, 2026
@TiagoLourinho
TiagoLourinho force-pushed the tl/add-on-error-cb branch 5 times, most recently from 564fd5e to 66aa72b Compare August 17, 2026 13:14
@TiagoLourinho
TiagoLourinho force-pushed the tl/add-on-error-cb branch 5 times, most recently from 8931d2a to b79833a Compare August 18, 2026 13:42
@TiagoLourinho
TiagoLourinho force-pushed the tl/add-on-error-cb branch 2 times, most recently from 8e380fd to 4be9e27 Compare August 18, 2026 14:24
@TiagoLourinho
TiagoLourinho force-pushed the tl/add-on-error-cb branch 2 times, most recently from 4a10dcd to c3ffd40 Compare August 25, 2026 13:38
@luismiguensfernandez
luismiguensfernandez merged commit e668728 into master Aug 27, 2026
14 checks passed
@luismiguensfernandez
luismiguensfernandez deleted the tl/add-on-error-cb branch August 27, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants