Skip to content

Rerun flaky test in vpe_circuits_test.py#1339

Open
arettig wants to merge 1 commit into
quantumlib:mainfrom
arettig:vpe_flakytest
Open

Rerun flaky test in vpe_circuits_test.py#1339
arettig wants to merge 1 commit into
quantumlib:mainfrom
arettig:vpe_flakytest

Conversation

@arettig
Copy link
Copy Markdown
Contributor

@arettig arettig commented Jun 4, 2026

This test was causing intermittent failures of the CI in the 5% of runs where the measured value is outside 2 standard deviations from the expected value. The built in @cirq.testing.retry_once_with_later_random_values decorator will now rerun the test with a new random seed.

The built in @cirq.testing.retry_once_with_later_random_values decorator
will rerun the test with a new random seed.
@arettig arettig requested a review from mhucka June 4, 2026 15:38
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the @cirq.testing.retry_once_with_later_random_values decorator to the test_single_timestep test in src/openfermion/circuits/vpe_circuits_test.py to mitigate potential test flakiness due to random values. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@arettig
Copy link
Copy Markdown
Contributor Author

arettig commented Jun 4, 2026

Looks like @cirq.testing.retry_once_with_later_random_values was added in cirq v1.5.0 but our ci.yaml uses v1.4.1:

cirq-version: [ 1.4.1 ]

@mhucka Is continuing support for 1.4.1 a hard requirement, or is it ok to bump that up in the CI?

@mhucka
Copy link
Copy Markdown
Collaborator

mhucka commented Jun 4, 2026

@mhucka Is continuing support for 1.4.1 a hard requirement, or is it ok to bump that up in the CI?

It is probably not a hard requirement, and now that you mention it, we should upgrade it to support the latest Cirq version if possible.

The pin in dev_tools/requirements/deps/runtime is actually a bit wider:

cirq-core>=1.4.1,<1.6.0

It ends up being 1.4.1 when pip-compile processes all the transitive dependencies, but I can no longer remember what the problem was the last time I tried to go higher than 1.6.

I'll open an issue about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants