fix: correct timeslot search and allocation in RequestTranslator#85
Open
youf3 wants to merge 2 commits into
Open
fix: correct timeslot search and allocation in RequestTranslator#85youf3 wants to merge 2 commits into
youf3 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
find_common_timeslotscomputing aslot_maskfrom the raw sequence length, which couldbe millions of slots for idle-wait agents (e.g. a node waiting for the full experiment). This
caused
bitarray.find()to return-1because the search pattern was longer than the searchspace; the fix caps the mask to
MAX_TIMESLOTS.find()returns-1so the failure surfaces with a clearmessage instead of silently producing a wrong slot assignment.
assigned = timeslot_mask[:timeslot]before advancing themask pointer, and skip empty assignments. The previous order could produce off-by-one
allocations.
submit()timeout from 5 s → 30 s to give agents enough time to respond under load.MAX_TIMESLOTSfrom 500 → 1000 to accommodate longer experiments.max_packet_size 268435455in the regression-test Mosquitto config to allow large DQCrequest payloads.