ci: fix high-severity zizmor findings - #208
Merged
Merged
Conversation
Keerthi Gowda (keerthi-go)
force-pushed
the
fix/zizmor-security-findings
branch
from
July 27, 2026 22:42
e8ede0c to
3bec11b
Compare
Fix the repo-wide high-severity zizmor findings across actions and workflows. Move template expressions out of shell run blocks by routing values through step env variables, replace GITHUB_ENV writes in push_to_repo with step outputs, and add a scoped ignore for the dynamic suite-based pkg-builder image reference. Also fix remaining template-injection findings in abi_checker and in the disabled installability validation step in pkg-build-reusable-workflow. Normalize touched step formatting so step-level env blocks are placed before run blocks for consistency. Signed-off-by: Keerthi Gowda <kbalehal@qti.qualcomm.com>
Keerthi Gowda (keerthi-go)
force-pushed
the
fix/zizmor-security-findings
branch
from
July 27, 2026 22:54
5364200 to
dfd7b40
Compare
Simon Beaudoin (simonbeaudoin0935)
approved these changes
Jul 28, 2026
Simon Beaudoin (simonbeaudoin0935)
left a comment
Simon Beaudoin (simonbeaudoin0935)
left a comment
Contributor
There was a problem hiding this comment.
works
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
envvariablespush_to_repoby using step outputs instead of writing toGITHUB_ENVzizmor: ignore[unpinned-images]for the dynamic suite-based pkg-builder container imageValidation
zizmor --config /tmp/zizmor-policy.yml --min-severity high --persona regular .