qcom-purwa: remove QCOM_VFAT_SECTOR_SIZE overwrite for IQ-X5121

[Shoudi Li (shoudil)]

Remove the overwrite to use sector size 4096 as UFS build is enabled by default.

Fix the efi mount failure on UFS build:
[ 2122.484676] FAT-fs (sda1): logical sector size too small for device (logical sector size = 512)

[Koen Kooi (koenkooi)]

Do we need to support non-UFS storage, like eMMC? And if so, would this change break that?

[github-actions]

Test run workflow

Test jobs for commit dd85584

qcom-distro_linux-qcom-6.18
Pass: 229 | Fail: 5 | Total: 259

qcom-distro
Pass: 10 | Fail: 1 | Total: 11

nodistro
Pass: 10 | Fail: 0 | Total: 10

[test-reporting-app]

Test Results

   67 files  +   46    318 suites  +297   3h 10m 42s ⏱️ + 2h 15m 15s
  153 tests +  142    140 ✅ +  136   1 💤 + 1  12 ❌ +5 
2 088 runs  +1 903  2 050 ✅ +1 873  25 💤 +25  13 ❌ +5 

For more details on these failures, see this check.

Results for commit dd85584. ± Comparison against base commit 2be91de.

♻️ This comment has been updated with latest results.

[Shoudi Li (shoudil)]

Do we need to support non-UFS storage, like eMMC? And if so, would this change break that?

Good question, on Hamoa/Purwa, both UFS and NVMe need to be supported. but only one HLOS build is supported, currently UFS is enabled by default. we are also considering to support multiple builds for diff storages, details on PR: #1736.
From our validation, efi.bin with 4096 sector size works on both NVMe and UFS. we only hit mount issue for efi.bin with 512 sector size on UFS build. This PR remove the overwrite 512 and use 4096 sector size, then same efi.bin will work well on both eMMC and UFS build.

[qcomlnxci]

Test Coral run workflow

Test jobs for commit 92c9ce4

• qcomdistro: multimedia image
  Pass: 10 | Fail: 0 | Total: 10
• qcomdistro: multimedia image-prop
  Pass: 42 | Fail: 0 | Total: 42

[Dmitry Baryshkov (lumag)]

Which conf are you changing? All of them at the same time? Which platform uses UFS? RB1? Write clear enough commit messages.

[Shoudi Li (shoudil)]

Which conf are you changing? All of them at the same time? Which platform uses UFS? RB1? Write clear enough commit messages.

Added board info in commit message.

[Dmitry Baryshkov (lumag)]

What are you changing? Not just conf.

[Ricardo Salveti (ricardosalveti)]

You are actually changing qcom-purwa.inc, say that instead (e.g. conf: qcom-purwa: remove ...).

[qcomlnxci]

Test Coral run workflow

Test jobs for commit 216e789

• qcomdistro: multimedia image
  Pass: 10 | Fail: 0 | Total: 10
• qcomdistro: multimedia image-prop
  Pass: 53 | Fail: 3 | Total: 56

[Shoudi Li (shoudil)]

What are you changing? Not just conf.

Changed to qcom-purwa as conf will cause confusion between conf file and conf folder.

[qcomlnxci]

Test Coral run workflow

Test jobs for commit dd85584

• qcomdistro: multimedia image
  Pass: 10 | Fail: 0 | Total: 10
• qcomdistro: multimedia image-prop
  Pass: 53 | Fail: 0 | Total: 53