minkipc: add patch for pkcs11 static initialization issue by jiaxli-QC · Pull Request #2739 · qualcomm-linux/meta-qcom

Jiaxing Li (jiaxli-QC) · 2026-07-15T10:33:41Z

meta-qcom uses OP-TEE optee_test v4.0.0, where pkcs11 test code takes the address of a compound literal in a static initializer (e.g. &(CK_BBOOL){CK_TRUE}). Under compiler optimization, the storage for such compound literals may be reused or overlap with other objects, which can result in invalid values being read back during the test.

Add a new patch (0003) to the minkipc recipe's optee_test source to fix this issue, and reference it in SRC_URI. The patch replaces the compound literal usage with statically allocated objects to ensure correct initialization and improve reliability.

Inherited from: #2726

github-actions · 2026-07-15T13:52:31Z

Test run workflow

Test jobs for commit `f98f934`

qcom-distro_linux-qcom-6.18
Pass: 221 | Fail: 0 | Total: 254

qcom-distro
Pass: 270 | Fail: 1 | Total: 302

nodistro
Pass: 10 | Fail: 0 | Total: 10

test-reporting-app · 2026-07-15T13:53:02Z

Test Results

110 files + 89 652 suites +631 9h 34m 59s ⏱️ + 8h 39m 32s
159 tests + 148 151 ✅ + 147 1 💤 + 1 7 ❌ ±0
4 212 runs +4 027 4 136 ✅ +3 959 64 💤 +64 12 ❌ +4

For more details on these failures, see this check.

Results for commit f98f934. ± Comparison against base commit 2be91de.

This pull request removes 4 and adds 152 tests. Note that renamed tests count towards both.

lava ‑ auto-login-action
lava ‑ boot-qdl-retry
lava ‑ flash-qdl
lava ‑ minimal-boot

0_AudioRecord_Config01 ‑ AudioRecord_Config01
0_BT_FW_KMD_Service ‑ BT_FW_KMD_Service
0_GStreamer_Video_Encode_h264_480p ‑ GStreamer_Video_Encode_h264_480p
0_Libcamera_cam ‑ Libcamera_cam
0_Weston_Runtime_Preflight ‑ Weston_Runtime_Preflight
0_hotplug ‑ hotplug
10_AudioRecord ‑ AudioRecord
10_Docker_Kernel_Config ‑ Docker_Kernel_Config
10_Kubernetes_Kernel_Config ‑ Kubernetes_Kernel_Config
11_DSP_AudioPD ‑ DSP_AudioPD
…

♻️ This comment has been updated with latest results.

Ricardo Salveti (ricardosalveti) · 2026-07-16T01:36:07Z

Why are we having this PR which is duplicating #2726 and ignoring the review comments which were already made there?

qcomlnxci · 2026-07-16T02:02:47Z

Test Coral run workflow

Test jobs for commit `14b6a01`

qcomdistro: multimedia image-prop
Pass: 27 | Fail: 2 | Total: 29
qcomdistro: multimedia image
Pass: 9 | Fail: 0 | Total: 9

Harshal Dev (harshaldev27) · 2026-07-16T07:12:37Z

Why are we having this PR which is duplicating #2726 and ignoring the review comments which were already made there?

Hi Ricardo Salveti (@ricardosalveti) , I checked with the original PR owner, they informed me that they are unable to validate the PR due to environment setup issues on their Linux machine. Hence, they've closed that PR and asked Jiaxing Li (@jiaxli-QC) to take over.

Jiaxing Li (@jiaxli-QC) can you please take care of the comments provided on the other PR and ensure we are aligned with the expectations here?

Harshal Dev (harshaldev27) · 2026-07-16T07:13:57Z

+Modified the compound literals used for session object templates to avoid problems arising from taking the address of a compound literal during
+static initialization.
+
+Upstream-Status: Inappropriate [tests applicable for optee]


This Upstream-Status is wrong, please mention the status as 'Submitted/Merged' and explain that this patch for back-porting the fix to our v4.0.0 tag of optee-test.

commit: 75f4e20

Updated.

For Upstream-Status item, set the status as Backport [https://github.com/OP-TEE/optee_test/pull/821/changes/9dd9d864042871518a257af3a46f53dc299ae778].
Please refer to guidance: https://docs.yoctoproject.org/dev/contributor-guide/recipe-style-guide.html#patch-upstream-status

Add the context in commit message

Jiaxing Li (jiaxli-QC) · 2026-07-16T10:06:13Z

Why are we having this PR which is duplicating #2726 and ignoring the review comments which were already made there?

Hi Ricardo Salveti (Ricardo Salveti (@ricardosalveti)) , I checked with the original PR owner, they informed me that they are unable to validate the PR due to environment setup issues on their Linux machine. Hence, they've closed that PR and asked Jiaxing Li (Jiaxing Li (@jiaxli-QC)) to take over.

Jiaxing Li (Jiaxing Li (@jiaxli-QC)) can you please take care of the comments provided on the other PR and ensure we are aligned with the expectations here?

Yes, Updated. Please review.

All test cases for PKCS#11 passed on PURWA.

~# xtest_qtee
Run test suite with level=0

TEE test application started over default TEE instance
######################################################
#
# pkcs11
#
######################################################
.
.
.
+-----------------------------------------------------
Result of testsuite pkcs11:
pkcs11_1000 OK
pkcs11_1001 OK
pkcs11_1002 OK
pkcs11_1003 OK
pkcs11_1004 OK
pkcs11_1005 OK
pkcs11_1006 OK
pkcs11_1007 OK
pkcs11_1008 OK
pkcs11_1009 OK
pkcs11_1010 OK
pkcs11_1011 OK
pkcs11_1012 OK
pkcs11_1013 OK
pkcs11_1014 OK
pkcs11_1015 OK
pkcs11_1017 OK
pkcs11_1020 OK
pkcs11_1022 OK
pkcs11_1023 OK
pkcs11_1024 OK
+-----------------------------------------------------
3580 subtests of which 0 failed
21 test cases of which 0 failed
0 test cases were skipped
TEE test application done!

qcomlnxci · 2026-07-16T20:20:01Z

Test Coral run workflow

Test jobs for commit `75f4e20`

qcomdistro: multimedia image
Pass: 10 | Fail: 1 | Total: 11
qcomdistro: multimedia image-prop
Pass: 41 | Fail: 1 | Total: 42

Anuj Mittal (anujm1) · 2026-07-17T09:09:33Z

Add a new patch (0003) to the minkipc recipe's optee_test source to
fix this issue, and reference it in SRC_URI.

Which issue? The issue is mentioned in PR description but not the commit message.

Jiaxing Li (jiaxli-QC) · 2026-07-17T10:11:33Z

Add a new patch (0003) to the minkipc recipe's optee_test source to
fix this issue, and reference it in SRC_URI.

Which issue? The issue is mentioned in PR description but not the commit message.

I think that I have described the issue in the second paragraph of the commit message and explained why we need this patch. Please review it.

minkipc: add patch for pkcs11 static initialization issue
Add a new patch (0003) to the minkipc recipe's optee_test source to
fix this issue, and reference it in SRC_URI.
This patch is required because meta-qcom uses OP-TEE optee_test v4.0.0,
where taking the address of a compound literal in a static initializer
(&(CK_BBOOL){CK_TRUE} etc.) may be reused or overlapped by the compiler
under optimization, which can result in invalid values.
Backport of OP-TEE/optee_test@31fa5e6.

Signed-off-by: Jiaxing Li jiaxing.li@oss.qualcomm.com

Dmitry Baryshkov (lumag) · 2026-07-17T13:36:02Z

Start by describing the issue.

meta-qcom uses OP-TEE optee_test v4.0.0, where pkcs11 test code takes the address of a compound literal in a static initializer (e.g. &(CK_BBOOL){CK_TRUE}). Under compiler optimization, the storage for such compound literals may be reused or overlap with other objects, which can result in invalid values being read back during the test. Add a new patch (0003) to the minkipc recipe's optee_test source to fix this issue, and reference it in SRC_URI. The patch replaces the compound literal usage with statically allocated objects to ensure correct initialization and improve reliability. Backport of OP-TEE/optee_test@31fa5e6. Signed-off-by: Jiaxing Li <jiaxing.li@oss.qualcomm.com>

Jiaxing Li (jiaxli-QC) · 2026-07-20T06:56:34Z

Update commit message.
(f98f934)

qcomlnxci · 2026-07-20T17:46:38Z

Test Coral run workflow

Test jobs for commit `f98f934`

qcomdistro: multimedia image
Pass: 10 | Fail: 0 | Total: 10
qcomdistro: multimedia image-prop
Pass: 54 | Fail: 2 | Total: 56

Jiaxing Li (jiaxli-QC) requested review from Anuj Mittal (anujm1), Koen Kooi (koenkooi), Dmitry Baryshkov (lumag), Nicolas Dechesne (ndechesne), Ricardo Salveti (ricardosalveti) and Viswanath Kraleti (vkraleti) as code owners July 15, 2026 10:33

Harshal Dev (harshaldev27) suggested changes Jul 16, 2026

View reviewed changes

Jiaxing Li (jiaxli-QC) force-pushed the fix/pkcs11-compound_variable_fix branch 2 times, most recently from a64f430 to 75f4e20 Compare July 16, 2026 09:36

Jiaxing Li (jiaxli-QC) changed the title ~~optee-test: pkcs11: Fix static initialization issue caused by compound literal address~~ minkipc: add patch for pkcs11 static initialization issue Jul 16, 2026

Ricardo Salveti (ricardosalveti) approved these changes Jul 16, 2026

View reviewed changes

Ricardo Salveti (ricardosalveti) added the backport wrynose label Jul 16, 2026

Jiaxing Li (jiaxli-QC) force-pushed the fix/pkcs11-compound_variable_fix branch from 75f4e20 to f98f934 Compare July 20, 2026 06:55

Jiaxing Li (jiaxli-QC) requested a review from Ricardo Salveti (ricardosalveti) July 20, 2026 06:57

Anuj Mittal (anujm1) approved these changes Jul 21, 2026

View reviewed changes

Uh oh!

Conversation

Jiaxing Li (jiaxli-QC) commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test run workflow

Test jobs for commit f98f934

Uh oh!

test-reporting-app Bot commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Ricardo Salveti (ricardosalveti) commented Jul 16, 2026

Uh oh!

qcomlnxci commented Jul 16, 2026

Test Coral run workflow

Test jobs for commit 14b6a01

Uh oh!

Harshal Dev (harshaldev27) commented Jul 16, 2026

Uh oh!

Harshal Dev (harshaldev27) Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jiaxing Li (jiaxli-QC) Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jiaxing Li (jiaxli-QC) commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qcomlnxci commented Jul 16, 2026

Test Coral run workflow

Test jobs for commit 75f4e20

Uh oh!

Anuj Mittal (anujm1) commented Jul 17, 2026

Uh oh!

Jiaxing Li (jiaxli-QC) commented Jul 17, 2026

Uh oh!

Dmitry Baryshkov (lumag) commented Jul 17, 2026

Uh oh!

Jiaxing Li (jiaxli-QC) commented Jul 20, 2026

Uh oh!

qcomlnxci commented Jul 20, 2026

Test Coral run workflow

Test jobs for commit f98f934

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Jiaxing Li (jiaxli-QC) commented Jul 15, 2026 •

edited

Loading

github-actions Bot commented Jul 15, 2026 •

edited

Loading

Test jobs for commit `f98f934`

test-reporting-app Bot commented Jul 15, 2026 •

edited

Loading

Test jobs for commit `14b6a01`

Harshal Dev (harshaldev27) Jul 16, 2026 •

edited

Loading

Jiaxing Li (jiaxli-QC) Jul 16, 2026 •

edited

Loading

Jiaxing Li (jiaxli-QC) commented Jul 16, 2026 •

edited

Loading

Test jobs for commit `75f4e20`

Test jobs for commit `f98f934`