systemd-boot: add EFI_MEMORY_ATTRIBUTE_PROTOCOL warning downgrade patch#2730
systemd-boot: add EFI_MEMORY_ATTRIBUTE_PROTOCOL warning downgrade patch#2730aswinm94 wants to merge 1 commit into
Conversation
Test Results 110 files ±0 657 suites ±0 5h 44m 19s ⏱️ - 1h 38m 2s For more details on these failures, see this check. Results for commit d69cf39. ± Comparison against base commit cf1ada4. This pull request removes 4 tests.♻️ This comment has been updated with latest results. |
Dmitry Baryshkov (lumag)
left a comment
Dmitry Baryshkov (lumag)
left a comment
There was a problem hiding this comment.
Also you are not changing the "boot" recipe. Don't blindly c&p the description of the patch. Write a suitable commit message.
| logging at LOG_DEBUG instead. Warnings are still emitted for | ||
| other UEFI >= 2.10 firmware that lack the protocol. | ||
|
|
||
| Upstream-Status: Pending [platform-specific: works around |
There was a problem hiding this comment.
No Pending patches, please. Post it and get reviewed.
There was a problem hiding this comment.
This issue is not specific to qualcomm, please fix in either u-boot or in systemd upstream, and once done backport to the respective projects (e.g. systemd -> oe-core, u-boot-qcom, here).
There was a problem hiding this comment.
Dmitry Baryshkov (@lumag) , Ricardo Salveti (@ricardosalveti)
The change has been merged in upstream
systemd/systemd#43017
backported the submitted patch
There was a problem hiding this comment.
Great, can you send to oe-core as well? Justifying that it is useful to reduce the boot time when booting with u-boot based firmware.
aswinm94
changed the title
|
|
||
| SRC_URI:append:qcom = " \ | ||
| file://0001-boot-stub-honor-PE-SectionAlignment-when-loading-inn.patch \ | ||
| file://0002-boot-downgrade-EFI_MEMORY_ATTRIBUTE_PROTOCOL-warning.patch \ |
There was a problem hiding this comment.
Also, we need to patch both recipes-core/systemd/systemd-boot_%.bbappend and recipes-core/systemd/systemd_%.bbappend, since systemd-boot produces the efi binary that gets into the deploy folder, but the efi binary that is available as a package comes from systemd (it is an issue in oe-core itself).
Add backport systemd patch that downgrades the EFI_MEMORY_ATTRIBUTE_PROTOCOL missing message from warning to debug. U-Boot currently does not implement EFI_MEMORY_ATTRIBUTE_PROTOCOL, causing systemd to display a warning during every boot on EFI 2.10+ platforms. The warning triggers log_wait() behavior, introducing an unnecessary boot-time delay even though the condition is a known U-Boot limitation and requires no user action. Include the patch in the systemd & systemd-boot recipe to suppress the non-actionable warning and avoid the associated boot delay on U-Boot-based systems. Signed-off-by: Aswin Murugan <aswin.murugan@oss.qualcomm.com>
4 participants
Add backport systemd-boot patch that downgrades the
EFI_MEMORY_ATTRIBUTE_PROTOCOL missing message from warning to debug.
U-Boot currently does not implement EFI_MEMORY_ATTRIBUTE_PROTOCOL,
causing systemd-boot to display a warning during every boot on
EFI 2.10+ platforms. The warning triggers log_wait() behavior,
introducing an unnecessary boot-time delay even though the
condition is a known U-Boot limitation and requires no user action.
Include the patch in the systemd-boot recipe to suppress the
non-actionable warning and avoid the associated boot delay on
U-Boot-based systems.
upstream-status: Backport [https://github.com/systemd/systemd/pull/43017]