Skip to content

firmware-qcom-cdt-shikra: add CDT for Shkra IQS ITP board#2729

Open
vivpuar wants to merge 1 commit into
qualcomm-linux:masterfrom
vivpuar:shikra-cdt
Open

firmware-qcom-cdt-shikra: add CDT for Shkra IQS ITP board#2729
vivpuar wants to merge 1 commit into
qualcomm-linux:masterfrom
vivpuar:shikra-cdt

Conversation

@vivpuar

@vivpuar vivpuar commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add CDT for Shikra IQS ITP board.

@vivpuar
firmware-qcom-cdt-shikra: add cdt for Shikra IQS ITP board
36c75ac 
Add cdt artifact for Shikra IQS ITP board so that it can be part of
the build.

Signed-off-by: Vivek Puar <vpuar@qti.qualcomm.com>
lumag
Dmitry Baryshkov (lumag) requested changes Jul 13, 2026
View reviewed changes
Comment thread conf/machine/shikra-evk.conf Outdated
"

QCOM_CDT_FILE = "cdt_cq2390_itp_0.2.0"
QCOM_CDT_FILE = "cdt_iq2390_itp_0.4.0"

@lumag Dmitry Baryshkov (lumag) Jul 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@vivpuar vivpuar Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was an ask to make IQS variant as default as IQS variant is PORed for Shikra.

@lumag Dmitry Baryshkov (lumag) Jul 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tree variants are equal. I think I have left a similar comment in one of the PRs. Please work on being able to support generation of multiple qcomflash archives, each having the distinct set of boot firmware, CDT anf partition files. Please find the PR and team up with the engineers who received the comment.

@vivpuar vivpuar Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will check for the PR and will work to create multiple qcomflash archives

@ricardosalveti

Ricardo Salveti (ricardosalveti) commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Adding a new CDT is fine, by why changing the default? The extra cdt will be available in qcomflash as well, you can pick the one you want when flashing, unless what Dmitry Baryshkov (@lumag) suggested gets implemented.

@vivpuar

vivpuar commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Adding a new CDT is fine, by why changing the default? The extra cdt will be available in qcomflash as well, you can pick the one you want when flashing, unless what Dmitry Baryshkov (Dmitry Baryshkov (@lumag)) suggested gets implemented.

Will update this PR to only add the CDT, and will explore on the way to support generation of multiple qcomflash archives.

@vivpuar vivpuar changed the title shikra-evk: add CDT for Shkra IQS ITP board firmware-qcom-cdt-shikra: add CDT for Shkra IQS ITP board Jul 14, 2026
@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown

Test run workflow

Test jobs for commit 36c75ac

nodistro
Pass: 10 | Fail: 0 | Total: 10 qcom-distro_linux-qcom-6.18
Pass: 212 | Fail: 1 | Total: 237 qcom-distro
Pass: 9 | Fail: 1 | Total: 10

@test-reporting-app

test-reporting-app Bot commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results

  110 files  ± 0    657 suites  ±0   6h 11m 52s ⏱️ - 5h 19m 40s
  157 tests  -  4    155 ✅ + 36   2 💤 ± 0  0 ❌  - 40 
4 238 runs  +29  4 185 ✅ +121  53 💤  - 15  0 ❌  - 77 

Results for commit 36c75ac. ± Comparison against base commit 37c795a.

This pull request removes 4 tests. 
lava ‑ auto-login-action
lava ‑ lava-test-retry
lava ‑ lava-test-shell
lava ‑ minimal-boot
This pull request skips 1 and un-skips 1 tests. 
6_AudioRecord ‑ AudioRecord

11_Ethernet ‑ Ethernet

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown

Test run workflow

Test jobs for commit 36c75ac

nodistro
Pass: 10 | Fail: 0 | Total: 10 qcom-distro_linux-qcom-6.18
Pass: 229 | Fail: 0 | Total: 255 qcom-distro
Pass: 268 | Fail: 2 | Total: 297

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown

Test run workflow

Test jobs for commit 36c75ac

nodistro
Pass: 10 | Fail: 0 | Total: 10 qcom-distro_linux-qcom-6.18
Pass: 233 | Fail: 0 | Total: 259 qcom-distro
Pass: 277 | Fail: 2 | Total: 306

1 similar comment
@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown

Test run workflow

Test jobs for commit 36c75ac

nodistro
Pass: 10 | Fail: 0 | Total: 10 qcom-distro_linux-qcom-6.18
Pass: 233 | Fail: 0 | Total: 259 qcom-distro
Pass: 277 | Fail: 2 | Total: 306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lumag Dmitry Baryshkov (lumag) lumag requested changes
@koenkooi Koen Kooi (koenkooi) koenkooi approved these changes
@ricardosalveti Ricardo Salveti (ricardosalveti) ricardosalveti approved these changes
@vkraleti Viswanath Kraleti (vkraleti) Awaiting requested review from vkraleti vkraleti is a code owner
@ndechesne Nicolas Dechesne (ndechesne) Awaiting requested review from ndechesne ndechesne is a code owner
@anujm1 Anuj Mittal (anujm1) Awaiting requested review from anujm1 anujm1 is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vivpuar @ricardosalveti @lumag @koenkooi