arm64: dts: qcom: rename rb3gen2 industrial mezzanine UART BT overlay

[Rahul Samana (rahul-samana)]

Rename the RB3 Gen2 industrial mezzanine subtype 13 overlay from the old M.2 Cologne name to a name that describes the actual board-level routing change.

Subtype 13 identifies a reworked RB3 Gen2 industrial mezzanine board where the M.2 slot is routed for Bluetooth over UART instead of the default Bluetooth-over-USB configuration.

This change only renames the DTSO and composed DTB target. Functional DTS content remains unchanged

[qlijarvis]

PR #1534 — validate-patch

PR: #1534

Verdict	Issues	Detailed Report
❌	1	Full report

Final Summary

1. Lore link present: No — no lore.kernel.org link found; commit has no vendor prefix to indicate vendor-only status
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — appears to be vendor-specific refactoring (file rename for clarity); no indication of upstream posting
4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1534 - arm64: dts: qcom: rename rb3gen2 industrial mezzanine UART BT overlay
Upstream commit: N/A
Verdict: ❌ FAIL

Commit Message

Check	Status	Note
Subject matches upstream	N/A	No upstream source
Body preserves rationale	✅	Clear explanation of rename rationale
Fixes tag present/correct	N/A	Not a fix
Authorship preserved	✅	Proper Qualcomm author
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
arch/arm64/boot/dts/qcom/Makefile	✅	Consistent rename across 3 references
qcs6490-rb3gen2-industrial-mezzanine-m2-cologne.dtso → qcs6490-rb3gen2-industrial-mezzanine-bt-uart.dtso	✅	Pure file rename, no content changes

Issues

Critical:

1. Missing vendor prefix — Commit lacks a prefix (QCLINUX:, PENDING:, etc.) to indicate this is vendor-specific work. Without a prefix or lore link, the commit's upstream intent is ambiguous.

2. Missing Signed-off-by trailer — Required by kernel development process (DCO). Author must add Signed-off-by: Rahul Samana <rahul.samana@oss.qualcomm.com>.

3. Not present in qcom-next or topics — Per integration_presence_report.md, this commit is missing from both qcom-next and all topic branches. This is a validation failure per the skill requirements.

Minor:

• The rename improves clarity (cologne → bt-uart describes the hardware routing), but the commit message could explicitly state whether this change should be upstreamed or is vendor-only.

Verdict

Do not merge until:

1. Author adds appropriate vendor prefix (recommend QCLINUX: if vendor-only, or PENDING: if intended for upstream later)
2. Author adds Signed-off-by: trailer
3. Commit is present in qcom-next or an appropriate topic branch

Final Summary

1. Lore link present: No — no lore.kernel.org link found; commit has no vendor prefix to indicate vendor-only status
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — appears to be vendor-specific refactoring (file rename for clarity); no indication of upstream posting
4. PR present in qcom-next/topics: Fail — 1/1 commit(s) are missing from both qcom-next and topics (per integration_presence_report.md)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: a5cf3debd8c3c660711ad586ad4bb84e9ca42635
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit	Subject	qcom-next	topics	Final
1/1	[PATCH] arm64: dts: qcom: rename rb3gen2 industrial mezzanine UART BT	missing - no subject, patch-id, or full tree-content match found	missing - no subject, patch-id, or full tree-content match found	missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

[qlijarvis]

PR #1534 — checker-log-analyzer

PR: #1534
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29757283967

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	1 error, 1 warning
dt-binding-check	⏭️	No binding changes
dtb-check	❌	Pre-existing tree errors exposed by renamed DTB
sparse-check	⏭️	No C/H changes
check-uapi-headers	⏭️	No C/H changes
check-patch-compliance	❌	Missing subject prefix
tag-check	❌	Missing subject prefix (mandatory for non-qcom-next branches)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1534 - arm64: dts: qcom: rename rb3gen2 industrial mezzanine UART BT overlay
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/29757283967

Checker	Result	Summary
checkpatch	❌	1 error, 1 warning
dt-binding-check	⏭️	No binding changes
dtb-check	❌	Pre-existing tree errors exposed by renamed DTB
sparse-check	⏭️	No C/H changes
check-uapi-headers	⏭️	No C/H changes
check-patch-compliance	❌	Missing subject prefix
tag-check	❌	Missing subject prefix (mandatory for non-qcom-next branches)

---

❌ checkpatch

Root cause: Commit ca23039 is missing Signed-off-by: trailer and has a long commit body line.

Failure details:

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#7: 
The RB3 Gen2 industrial mezzanine subtype 13 configuration describes a board-level routing change where the M.2 slot is used for Bluetooth over UART instead of Bluetooth over USB.

ERROR: Missing Signed-off-by: line(s)

ca23039aebc0497f0c2d3851ae4246364e9b8ab5 total: 1 errors, 1 warnings, 0 checks, 15 lines checked

Fix:

1. Add Signed-off-by: Rahul Samana <rahul.samana@oss.qualcomm.com> to the commit message
2. Wrap the long commit body line at 75 characters:

   The RB3 Gen2 industrial mezzanine subtype 13 configuration describes
   a board-level routing change where the M.2 slot is used for Bluetooth
   over UART instead of Bluetooth over USB.
   

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git a5cf3debd8c3c660711ad586ad4bb84e9ca42635..15655645873a120a8fdec70cac66a04ae0dd3e73

Fix command:

git rebase -i a5cf3debd8c3c660711ad586ad4bb84e9ca42635
# mark commit as 'edit'
git commit --amend
# Add Signed-off-by and wrap the long line
git rebase --continue

---

❌ dtb-check

Root cause: The renamed DTB qcs6490-rb3gen2-industrial-mezzanine-bt-uart.dtb exposes pre-existing tree validation errors that were already present in the base tree.

Failure details:

/opt/actions-runner/_work/kernel-config/kernel-config/kernel/temp-out/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine-bt-uart.dtb: pinctrl@f100000 (qcom,sc7280-pinctrl): gp_mn_active-state: 'oneOf' conditional failed, one must be fixed:
	'bias-disable', 'drive-strength', 'function', 'pins' do not match any of the regexes: '-pins$', '^pinctrl-[0-9]+$'
	'gp_mn' is not one of ['atest_char', 'atest_char0', ..., 'vsense_trigger']

/opt/actions-runner/_work/kernel-config/kernel-config/kernel/temp-out/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine-bt-uart.dtb: lvds-bridge@29 (lontium,lt9211c): 'vccio-supply' is a required property

/opt/actions-runner/_work/kernel-config/kernel-config/kernel/temp-out/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine-bt-uart.dtb: serial@990000 (qcom,geni-uart): {...} is valid under each of {'required': ['interrupts-extended']}, {'required': ['interrupts']}

Analysis: These are pre-existing tree issues not introduced by this PR:

1. gp_mn_active-state pinctrl error — The pinctrl node uses gp_mn as a function name, which is not in the allowed list for qcom,sc7280-pinctrl. This is a pre-existing binding/DTS mismatch in the base tree.

2. lvds-bridge@29 missing vccio-supply — The lontium,lt9211c binding requires vccio-supply, but the DTS doesn't provide it. Pre-existing issue.

3. serial@990000 ambiguous interrupt specification — The UART node has both interrupts and interrupts-extended, which triggers a schema warning. Pre-existing issue.

This PR only renames the file from qcs6490-rb3gen2-industrial-mezzanine-m2-cologne.dtso to qcs6490-rb3gen2-industrial-mezzanine-bt-uart.dtso (100% rename, no content changes). The dtb-check failures are exposed because the renamed DTB is now being built and validated, but the errors existed before this PR.

Fix: These are tree-wide issues that should be fixed separately:

• Add gp_mn to the allowed function list in qcom,sc7280-pinctrl.yaml, or rename the pinctrl state to match an allowed function
• Add vccio-supply to the lvds-bridge@29 node
• Remove either interrupts or interrupts-extended from the UART node (keep interrupts-extended if wake-up GPIO is needed)

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine-bt-uart.dtb

---

❌ check-patch-compliance

Root cause: Commit subject does not start with a required prefix (FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT:).

Failure details:

Checking commit: arm64: dts: qcom: rename rb3gen2 industrial mezzanine UART BT overlay
Commit summary does not start with a required prefix

Fix: Add an appropriate prefix to the commit subject. Since this appears to be a vendor-internal change (file rename for clarity), the correct prefix depends on the patch origin:

• If this change was posted to a mailing list → FROMLIST:
• If taken from a maintainer tree → FROMGIT:
• If merged into mainline → UPSTREAM:
• If this is vendor-only → QCLINUX: (note: this will still fail check-patch-compliance, which only accepts upstream-linkable prefixes)

Recommended action:

git rebase -i a5cf3debd8c3c660711ad586ad4bb84e9ca42635
# mark commit as 'edit'
git commit --amend -m "QCLINUX: arm64: dts: qcom: rename rb3gen2 industrial mezzanine UART BT overlay"
# (keep the rest of the commit message)
git rebase --continue

Note: If you use QCLINUX:, the check-patch-compliance checker will still fail because it only accepts FROMLIST:, FROMGIT:, UPSTREAM:, and BACKPORT:. This is a known limitation for vendor-only commits. If the change can be posted upstream, use FROMLIST: and add a Link: trailer.

Reproduce locally:

# The check-patch-compliance.sh script from kernel-checkers repo
bash ../kernel-checkers/check-patch-compliance.sh --kernel-src . --base a5cf3debd8c3c660711ad586ad4bb84e9ca42635 --head ca23039aebc0497f0c2d3851ae4246364e9b8ab5

---

❌ tag-check

Root cause: Commit subject does not start with a required prefix tag. This check is mandatory for all branches except qcom-next and qcom-next-staging.

Failure details:

Commit ca23039aebc0 ("arm64: dts: qcom: rename rb3gen2 industrial mezzanine UART BT overlay"): subject line does not start with a required prefix.
All branches except qcom-next and qcom-next-staging require one of:
FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:

Fix: Same as check-patch-compliance — add a prefix to the commit subject. Choose based on the patch origin:

Situation	Prefix
Posted to lore, not yet merged	FROMLIST:
In a maintainer git tree	FROMGIT:
Merged into Linus's tree	UPSTREAM:
Backported with modifications	BACKPORT:
Vendor-only, no upstream	QCLINUX:
Work-in-progress, not posted	PENDING:
Temporary fix, not for upstream	WORKAROUND:

Recommended:

git rebase -i a5cf3debd8c3c660711ad586ad4bb84e9ca42635
# mark commit as 'edit'
git commit --amend -m "QCLINUX: arm64: dts: qcom: rename rb3gen2 industrial mezzanine UART BT overlay"
git rebase --continue

---

Verdict

3 blockers must be fixed before merge:

1. checkpatch — Add Signed-off-by: trailer and wrap long commit body line
2. check-patch-compliance — Add subject prefix (e.g., QCLINUX:)
3. tag-check — Add subject prefix (same fix as dummy change #2)

1 non-blocker (pre-existing tree issue):

4. dtb-check — Pre-existing validation errors exposed by the renamed DTB; not introduced by this PR. These should be fixed in a separate patch series addressing the base tree issues.

Recommended action: Amend the commit to add Signed-off-by:, wrap the long line, and add a subject prefix (QCLINUX: if vendor-only, or FROMLIST:/UPSTREAM: if posted/merged upstream). The dtb-check failures can be ignored for this PR since they are pre-existing tree issues.

[qlijarvis]

PR #1534 — validate-patch

PR: #1534

Verdict	Issues	Detailed Report
✅	0	Full report

Final Summary

1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — vendor-only change, not posted upstream
4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1534 - QCLINUX: arm64: dts: qcom: rename rb3gen2 UART BT overlay
Upstream commit: N/A (vendor-only commit)
Verdict: ✅ PASS

Commit Message

Check	Status	Note
Subject matches upstream	N/A	Vendor-only commit, no upstream source
Body preserves rationale	✅	Clear explanation of rename rationale
Fixes tag present/correct	N/A	Not applicable for rename/refactor
Authorship preserved	✅	Consistent From: and Signed-off-by:
Backport note (if applicable)	N/A	Vendor-only commit

Diff

File	Status	Notes
arch/arm64/boot/dts/qcom/Makefile	✅	DTB target names updated consistently
qcs6490-rb3gen2-industrial-mezzanine-m2-cologne.dtso → qcs6490-rb3gen2-industrial-mezzanine-bt-uart.dtso	✅	Pure rename (100% similarity), no content changes

Verdict

Merge as-is. This is a well-formed vendor-only commit that renames a device tree overlay to better describe its hardware configuration (UART Bluetooth routing). The commit message clearly explains the rationale, all references are updated consistently, and the change is a pure refactor with no functional modifications.

Final Summary

1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — vendor-only change, not posted upstream
4. PR present in qcom-next/topics: No — commit not yet merged (0/1 commits present per integration_presence_report.md)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: a5cf3debd8c3c660711ad586ad4bb84e9ca42635
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit	Subject	qcom-next	topics	Final
1/1	[PATCH] QCLINUX: arm64: dts: qcom: rename rb3gen2 UART BT overlay	missing - no subject, patch-id, or full tree-content match found	missing - no subject, patch-id, or full tree-content match found	missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

[qlijarvis]

PR #1534 — checker-log-analyzer

PR: #1534
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29763105971

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	Passed
dt-binding-check	⏭️	Skipped (no binding changes)
dtb-check	❌	Failed (pre-existing issues in overlay)
sparse-check	⏭️	Skipped (no C/H changes)
check-uapi-headers	⏭️	Skipped (no C/H changes)
check-patch-compliance	❌	Failed (QCLINUX: prefix)
tag-check	N/A	Not required for qcom-next branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1534 - QCLINUX: arm64: dts: qcom: rename rb3gen2 UART BT overlay
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/29763105971
Target branch: qcom-next

Checker	Result	Summary
checkpatch	✅	Passed
dt-binding-check	⏭️	Skipped (no binding changes)
dtb-check	❌	Failed (pre-existing issues in overlay)
sparse-check	⏭️	Skipped (no C/H changes)
check-uapi-headers	⏭️	Skipped (no C/H changes)
check-patch-compliance	❌	Failed (QCLINUX: prefix)
tag-check	N/A	Not required for qcom-next branch

---

❌ dtb-check

Root cause: Pre-existing schema validation errors in the industrial mezzanine overlay files that are exposed by the rename operation (100% file rename, no content changes).

Failure details:

The renamed DTB qcs6490-rb3gen2-industrial-mezzanine-bt-uart.dtb triggers multiple schema validation errors:

1. gp_mn_active-state pinctrl validation failure:

   pinctrl@f100000 (qcom,sc7280-pinctrl): gp_mn_active-state: 'oneOf' conditional failed
   'gp_mn' is not one of [allowed function names...]
   

2. lvds-bridge@29 missing required property:

   lvds-bridge@29 (lontium,lt9211c): 'vccio-supply' is a required property
   

3. serial@990000 schema ambiguity:

   serial@990000 (qcom,geni-uart): is valid under each of {'required': ['interrupts-extended']}, {'required': ['interrupts']}
   

4. lvds-bridge@29 data-lanes validation:

   ports:port@0:endpoint:data-lanes:0: 1 was expected
   ports:port@0:endpoint:data-lanes:1: 2 was expected
   [...]
   

Analysis:

These errors are not introduced by this PR. The PR performs a 100% file rename (similarity index 100%) with zero content changes:

rename from arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine-m2-cologne.dtso
rename to arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine-bt-uart.dtso

The errors exist in the qcs6490-rb3gen2-industrial-mezzanine.dtso overlay file (which is included by the renamed overlay) and have been present in the tree before this PR. The dtb-check CI builds the newly named DTB target and exposes these pre-existing schema violations.

Fix:

These issues should be fixed in a separate PR targeting the qcs6490-rb3gen2-industrial-mezzanine.dtso file:

1. For gp_mn_active-state: Rename the pinctrl state node to follow the -pins suffix pattern required by the schema, or use a valid function name from the allowed list.

2. For vccio-supply: Add the required vccio-supply property to the lvds-bridge@29 node in the overlay.

3. For serial@990000 schema ambiguity: This is a schema warning (not an error) indicating the node satisfies multiple schema patterns. No action required unless the schema maintainers clarify the intent.

4. For data-lanes validation: Fix the data-lanes property in the LVDS bridge port endpoint to use the expected sequential values <1 2 3 4> instead of the current values.

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine-bt-uart.dtb

---

❌ check-patch-compliance

Root cause: The commit subject uses the QCLINUX: prefix, which is not in the checker's allowed prefix list.

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: rename rb3gen2 UART BT overlay
Commit summary does not start with a required prefix

Analysis:

The check-patch-compliance checker enforces a strict subset of allowed prefixes: FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:. It does not accept QCLINUX:, PENDING:, or WORKAROUND: prefixes.

This is a known limitation of the checker for vendor-only commits. The QCLINUX: prefix is valid and widely used in the Qualcomm Linux kernel tree for vendor-specific changes that have no upstream equivalent.

Fix:

No action required. This is a vendor-only DTS file rename with no upstream equivalent. The QCLINUX: prefix is correct and appropriate for this change. The checker failure is expected and can be safely ignored for vendor-only commits.

If you want the checker to pass, you would need to:

• Post the patch to a mailing list → change prefix to FROMLIST: + add Link: tag
• OR accept that vendor-only commits will always fail this checker

Reproduce locally:

# This checker requires the b4 tool and will attempt to fetch from lore.kernel.org
# For QCLINUX: prefixed commits, it will always fail as there is no upstream link

---

Verdict

Ready to merge with caveats:

• ✅ The PR itself is clean — it's a pure file rename with no content changes
• ✅ checkpatch passed — no coding style issues
• ❌ dtb-check failures are pre-existing issues in the overlay files, not introduced by this PR
• ❌ check-patch-compliance failure is expected for vendor-only QCLINUX: commits

Recommendation: Merge this PR as-is. The dtb-check errors should be addressed in a separate follow-up PR that fixes the schema validation issues in the qcs6490-rb3gen2-industrial-mezzanine.dtso overlay file.