Skip to content

WORKAROUND: arm64: dts: qcom: purwa-iot-som: Add vdda-qref supply for PCIe PHYs#1526

Open
ziyuezhang-123 wants to merge 1 commit into
qualcomm-linux:tech/all/workaroundfrom
ziyuezhang-123:for-all-workaround-purwa-qref-20260717
Open

WORKAROUND: arm64: dts: qcom: purwa-iot-som: Add vdda-qref supply for PCIe PHYs#1526
ziyuezhang-123 wants to merge 1 commit into
qualcomm-linux:tech/all/workaroundfrom
ziyuezhang-123:for-all-workaround-purwa-qref-20260717

Conversation

@ziyuezhang-123

@ziyuezhang-123 ziyuezhang-123 commented Jul 17, 2026

Copy link
Copy Markdown

All PCIe PHYs on X1P42100 require vdda-qref power supplies, but this is missing in the current PHY device tree nodes. The PCIe ports can still function because the regulator L3J, which vdda-qref consumes, is voted by other components.

Since the device tree should accurately describe the hardware, add the vdda-qref power supply explicitly in all PCIe PHY device nodes on the purwa-iot-som board.

Workaround will be reverted once the vote qref regulator for PCIe available in upstream.

CRs-Fixed: 4563581

… PCIe PHYs

All PCIe PHYs on X1P42100 require vdda-qref power supplies, but this is
missing in the current PHY device tree nodes. The PCIe ports can still
function because the regulator L3J, which vdda-qref consumes, is voted
by other components.

Since the device tree should accurately describe the hardware, add the
vdda-qref power supply explicitly in all PCIe PHY device nodes on the
purwa-iot-som board.

Workaround will be reverted once the vote qref regulator for PCIe
available in upstream.

Signed-off-by: Ziyue Zhang <ziyue.zhang@oss.qualcomm.com>
@qlijarvis

Copy link
Copy Markdown

PR #1526 — validate-patch

PR: #1526

Verdict Issues Detailed Report
⚠️ 1 Full report

Final Summary

  1. Lore link present: No — WORKAROUND: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only workaround, not posted upstream (commit message states "will be reverted once the vote qref regulator for PCIe available in upstream")
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1526 - WORKAROUND: arm64: dts: qcom: purwa-iot-som: Add vdda-qref supply for PCIe PHYs
Upstream commit: N/A (WORKAROUND: vendor-only temporary fix)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream N/A WORKAROUND: prefix; no upstream equivalent
Body preserves rationale Clear explanation of missing supply and workaround nature
Fixes tag present/correct N/A Not fixing a bug; adding missing hardware description
Authorship preserved From: matches Signed-off-by:
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/purwa-iot-som.dtsi Adds vdda-qref-supply to 4 PCIe PHY nodes consistently

Issues

  • ⚠️ Integration presence failure: Commit is missing from both qcom-next and all kernel topic branches. For a WORKAROUND commit, this may be expected if it's a new temporary fix, but it should be tracked for eventual removal when the upstream solution lands.

Verdict

Commit message and diff are correct for a WORKAROUND patch. The missing integration presence is flagged as a warning — verify this is intentional for a new workaround that hasn't been integrated yet.

Final Summary

  1. Lore link present: No — WORKAROUND: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only workaround, not posted upstream (commit message states "will be reverted once the vote qref regulator for PCIe available in upstream")
  4. PR present in qcom-next/topics: No — Fail: 1/1 commit(s) are missing from both qcom-next and topics (per integration_presence_report.md). This may be expected for a new workaround patch.

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: a5cf3debd8c3c660711ad586ad4bb84e9ca42635
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] WORKAROUND: arm64: dts: qcom: purwa-iot-som: Add vdda-qref missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1526 — checker-log-analyzer

PR: #1526
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29572521797

Checker Result Summary
Checker Result Summary
checkpatch No style issues
dt-binding-check ⏭️ No binding changes
dtb-check DTB validation passed
sparse-check ⏭️ No C/H file changes
check-uapi-headers ⏭️ No C/H file changes
check-patch-compliance WORKAROUND: prefix not in allowed list
tag-check N/A Skipped for qcom-next branch
qcom-next-check WORKAROUND: prefix is valid for qcom-next

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1526 - WORKAROUND: arm64: dts: qcom: purwa-iot-som: Add vdda-qref supply for PCIe PHYs
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/29572521797
Target branch: qcom-next

Checker Result Summary
checkpatch No style issues
dt-binding-check ⏭️ No binding changes
dtb-check DTB validation passed
sparse-check ⏭️ No C/H file changes
check-uapi-headers ⏭️ No C/H file changes
check-patch-compliance WORKAROUND: prefix not in allowed list
tag-check N/A Skipped for qcom-next branch
qcom-next-check WORKAROUND: prefix is valid for qcom-next

❌ check-patch-compliance

Root cause: The checker only accepts FROMLIST:, FROMGIT:, UPSTREAM:, and BACKPORT: prefixes, but the commit uses WORKAROUND:.

Failure details:

Checking commit: WORKAROUND: arm64: dts: qcom: purwa-iot-som: Add vdda-qref supply for PCIe PHYs
Commit summary does not start with a required prefix

Analysis:
This is a known limitation of the check-patch-compliance checker. The checker enforces a strict subset of prefixes (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:) and rejects vendor-specific prefixes like WORKAROUND:, QCLINUX:, and PENDING:.

However, since the target branch is qcom-next, vendor-specific prefixes are acceptable. The WORKAROUND: prefix is appropriate for this commit because:

  • It's a temporary workaround for missing upstream vdda-qref regulator support
  • The commit message explicitly states: "Workaround will be reverted once the vote qref regulator for PCIe available in upstream"
  • The qcom-next branch allows vendor-specific changes that are not yet upstream

Fix options:

Option 1 (Recommended for qcom-next): Accept the failure as a false positive. The commit is correctly tagged with WORKAROUND: and is appropriate for the qcom-next branch. No action needed.

Option 2 (If upstream posting is planned): If this change will be posted upstream, change the prefix to FROMLIST: and add a Link: tag pointing to the lore.kernel.org URL once posted.

Reproduce locally:

cd kernel-source
git log --oneline -1 e6c83949a1657e024fd5c3780e7b927a4ab3f239
# Verify the commit subject starts with WORKAROUND:

Verdict

Ready to merge. The check-patch-compliance failure is a false positive for the qcom-next branch. All other checkers passed or were correctly skipped. The WORKAROUND: prefix is appropriate for a temporary vendor-specific change targeting qcom-next.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No Component Found

Configuration Error: No component found for branch 'tech/all/workaround'.

There is no component associated with the provided branch in Polaris. Please verify the branch configuration.

Branch: tech/all/workaround

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants