FROMLIST: arm64: dts: qcom: hamoa/purwa: Add QREF regulator supplies

[qianyu-qcom]

Wire up the LDO supplies required by the QREF and refgen blocks on Purwa and Hamoa boards. Purwa's QREF topology is same as Hamoa's, so it reuses the same qcom,x1e80100-tcsr compatible and supply set rather than needing a dedicated one.

[qlijarvis]

PR #1514 — validate-patch

PR: #1514

Verdict	Issues	Detailed Report
❌	0	Full report

Final Summary

1. Lore link present: Yes - https://lore.kernel.org/linux-arm-msm/20260714-hamoa_tcsr_qref_0714_2-v1-0-13047922a376@oss.qualcomm.com/
2. Lore link matches PR commits: No - PR is missing 2 of 19 files from the upstream patch (x1e80100-honor-magicbook-art-14.dts and x1p42100-microsoft-sp12in.dts). The 17 files present have identical content.
3. Upstream patch status: ⏳ In review - Posted July 14, 2026; received Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> but not yet merged to maintainer tree or mainline
4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1514 - FROMLIST: arm64: dts: qcom: hamoa/purwa: Add QREF regulator supplies
Upstream commit: https://lore.kernel.org/linux-arm-msm/20260714-hamoa_tcsr_qref_0714_2-v1-0-13047922a376@oss.qualcomm.com/
Verdict: ❌ FAIL

Commit Message

Check	Status	Note
Subject matches upstream	✅	Subject correctly adapted with FROMLIST: prefix
Body preserves rationale	✅	Body text identical to upstream
Fixes tag present/correct	N/A	No Fixes tag in upstream patch
Authorship preserved	✅	Author Qiang Yu <qiang.yu@oss.qualcomm.com> matches lore
Backport note (if applicable)	N/A	Not a backport - FROMLIST prefix correct

Diff

File	Status	Notes
hamoa-iot-som.dtsi	✅	Content identical (context line numbers differ due to tree state)
hamoa-lenovo-ideacentre-mini-01q8x10.dts	✅	Content identical
purwa-iot-som.dtsi	✅	Content identical
x1-asus-vivobook-s15.dtsi	✅	Content identical
x1-asus-zenbook-a14.dtsi	✅	Content identical
x1-crd.dtsi	✅	Content identical
x1-dell-thena.dtsi	✅	Content identical
x1-hp-omnibook-x14.dtsi	✅	Content identical
x1-microsoft-denali.dtsi	✅	Content identical
x1e001de-devkit.dts	✅	Content identical
x1e78100-lenovo-thinkpad-t14s.dtsi	✅	Content identical
x1e80100-dell-xps13-9345.dts	✅	Content identical
x1e80100-lenovo-yoga-slim7x.dts	✅	Content identical
x1e80100-medion-sprchrgd-14-s1.dts	✅	Content identical
x1e80100-microsoft-romulus.dtsi	✅	Content identical
x1e80100-qcp.dts	✅	Content identical
x1p42100-lenovo-thinkbook-16.dts	✅	Content identical
x1e80100-honor-magicbook-art-14.dts	❌	Missing from PR - present in lore patch
x1p42100-microsoft-sp12in.dts	❌	Missing from PR - present in lore patch

Issues

Critical: Incomplete patch - missing 2 files from upstream

The PR patch is missing 2 device tree files that are present in the upstream lore patch (PATCH 3/3):

1. arch/arm64/boot/dts/qcom/x1e80100-honor-magicbook-art-14.dts - Missing the &tcsr regulator supply block
2. arch/arm64/boot/dts/qcom/x1p42100-microsoft-sp12in.dts - Missing the &tcsr regulator supply block

The lore patch modifies 19 files (adding QREF regulator supplies to all X1E80100/Hamoa/Purwa boards), but this PR only includes 17 files. The two Honor MagicBook Art 14 and Microsoft Surface Pro 12in boards are missing their regulator supply configurations.

All 17 files that are present have identical content to the lore patch (accounting for normal context line number differences due to tree state).

Verdict

Do not merge - This PR is an incomplete cherry-pick of the upstream patch. The missing files must be added to match the upstream patch exactly. Either:

1. Add the 2 missing files to this PR, or
2. If those board files don't exist in the target tree yet, document this as a partial backport in the commit message and explain which boards are intentionally excluded.

Final Summary

1. Lore link present: Yes - https://lore.kernel.org/linux-arm-msm/20260714-hamoa_tcsr_qref_0714_2-v1-0-13047922a376@oss.qualcomm.com/
2. Lore link matches PR commits: No - PR is missing 2 of 19 files from the upstream patch (x1e80100-honor-magicbook-art-14.dts and x1p42100-microsoft-sp12in.dts). The 17 files present have identical content.
3. Upstream patch status: ⏳ In review - Posted July 14, 2026; received Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> but not yet merged to maintainer tree or mainline
4. PR present in qcom-next/topics: Fail - Per integration_presence_report.md: 1/1 commit missing from both qcom-next and topics (expected for a FROMLIST patch not yet merged upstream)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: a5cf3debd8c3c660711ad586ad4bb84e9ca42635
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit	Subject	qcom-next	topics	Final
1/1	[PATCH] FROMLIST: arm64: dts: qcom: hamoa/purwa: Add QREF regulator	missing - no subject, patch-id, or full tree-content match found	missing - no subject, patch-id, or full tree-content match found	missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

[qlijarvis]

PR #1514 — checker-log-analyzer

PR: #1514
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29722917951

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	No style issues
dt-binding-check	⏭️	No binding changes
dtb-check	✅	All DTB validations passed
sparse-check	⏭️	No C/H file changes
check-uapi-headers	⏭️	No UAPI changes
check-patch-compliance	❌	b4 fetch failed for lore link
tag-check	✅	Subject has valid FROMLIST: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1514 - FROMLIST: arm64: dts: qcom: hamoa/purwa: Add QREF regulator supplies
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/29722917951

Checker	Result	Summary
checkpatch	✅	No style issues
dt-binding-check	⏭️	No binding changes
dtb-check	✅	All DTB validations passed
sparse-check	⏭️	No C/H file changes
check-uapi-headers	⏭️	No UAPI changes
check-patch-compliance	❌	b4 fetch failed for lore link
tag-check	✅	Subject has valid FROMLIST: prefix

---

❌ check-patch-compliance

Root cause: The Link: trailer points to a cover letter (patch 0) rather than the actual patch, causing b4 am to fail validation.

Failure details:

Checking commit: FROMLIST: arm64: dts: qcom: hamoa/purwa: Add QREF regulator supplies
Something seems wrong with the provided link. Please verify it
Try below command to run locally-
b4 am --single-message -C -l -3 https://lore.kernel.org/linux-arm-msm/20260714-hamoa_tcsr_qref_0714_2-v1-0-13047922a376@oss.qualcomm.com/

The link URL contains v1-0- which indicates it's the cover letter (patch 0 of a series). The check-patch-compliance checker expects either:

• A direct patch link (e.g., v1-1-<hash> for the first patch in the series)
• The series base URL without the message-ID suffix

Fix: Update the Link: trailer to point to the actual patch message-ID, not the cover letter:

git rebase -i <base_sha>   # mark commit as 'edit'
# Find the correct patch link (v1-1-...) from lore.kernel.org
git commit --amend
# Replace the Link: line with the correct patch URL
git rebase --continue

To find the correct link:

1. Visit https://lore.kernel.org/linux-arm-msm/20260714-hamoa_tcsr_qref_0714_2-v1-0-13047922a376@oss.qualcomm.com/
2. Click on the actual patch (not the cover letter) in the thread
3. Copy the message-ID URL from the browser (it should contain v1-1- or similar)
4. Update the commit message with the correct link

Reproduce locally:

b4 am --single-message -C -l -3 https://lore.kernel.org/linux-arm-msm/20260714-hamoa_tcsr_qref_0714_2-v1-0-13047922a376@oss.qualcomm.com/

---

Verdict

One blocker to fix: The Link: trailer must point to the actual patch message-ID, not the cover letter. All other checkers passed or were correctly skipped. Once the link is corrected, the PR should pass all checks.

[qianyu-qcom]

Hi
Can we bypass CI because the difference between PR and lore link is included by rebase.

Run bash ../kernel-checkers/check-patch-compliance.sh --kernel-src /opt/actions-runner/_work/kernel-config/kernel-config/kernel
Changed directory to /opt/actions-runner/_work/kernel-config/kernel-config/kernel
Checking commit: FROMLIST: arm64: dts: qcom: hamoa/purwa: Add QREF regulator supplies
Change is different from the one mentioned in Link

Leaving /opt/actions-runner/_work/kernel-config/kernel-config/kernel
/opt/actions-runner/_work/kernel-config/kernel-config
Error: Process completed with exit code 1.

[qlijarvis]

PR #1514 — validate-patch

PR: #1514

Verdict	Issues	Detailed Report
❌	0	Full report

Final Summary

1. Lore link present: Yes — https://lore.kernel.org/linux-arm-msm/20260714-hamoa_tcsr_qref_0714_2-v1-3-13047922a376@oss.qualcomm.com/

2. Lore link matches PR commits: No — PR is missing 2 of 19 DTS files present in lore patch 3/3 (x1e80100-honor-magicbook-art-14.dts and x1p42100-microsoft-sp12in.dts). The 17 files that are present have identical diff content (only context line numbers differ).

3. Upstream patch status: ✅ ACKed — Reviewed-by: Konrad Dybcio on 2026-07-15. Patch is under review and has received maintainer approval. Not yet merged into mainline.

4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1514 - FROMLIST: arm64: dts: qcom: hamoa/purwa: Add QREF regulator supplies
Upstream commit: https://lore.kernel.org/linux-arm-msm/20260714-hamoa_tcsr_qref_0714_2-v1-3-13047922a376@oss.qualcomm.com/
Verdict: ❌ FAIL

Commit Message

Check	Status	Note
Subject matches upstream	✅	Subject correctly adapted with FROMLIST: prefix
Body preserves rationale	✅	Body text matches lore patch verbatim
Fixes tag present/correct	N/A	No Fixes tag in upstream patch
Authorship preserved	✅	From: matches lore author (Qiang Yu) - correct for FROMLIST:
Backport note (if applicable)	N/A	Not a backport
Co-developed-by usage	✅	Not used
Link tag present	✅	Correct lore.kernel.org link present
Signed-off-by chain	✅	Original author's SoB present

Diff

File	Status	Notes
hamoa-iot-som.dtsi	✅	Identical to lore patch (context line numbers differ)
hamoa-lenovo-ideacentre-mini-01q8x10.dts	✅	Identical to lore patch
purwa-iot-som.dtsi	✅	Identical to lore patch
x1-asus-vivobook-s15.dtsi	✅	Identical to lore patch
x1-asus-zenbook-a14.dtsi	✅	Identical to lore patch
x1-crd.dtsi	✅	Identical to lore patch
x1-dell-thena.dtsi	✅	Identical to lore patch
x1-hp-omnibook-x14.dtsi	✅	Identical to lore patch
x1-microsoft-denali.dtsi	✅	Identical to lore patch
x1e001de-devkit.dts	✅	Identical to lore patch
x1e78100-lenovo-thinkpad-t14s.dtsi	✅	Identical to lore patch
x1e80100-dell-xps13-9345.dts	✅	Identical to lore patch
x1e80100-lenovo-yoga-slim7x.dts	✅	Identical to lore patch
x1e80100-medion-sprchrgd-14-s1.dts	✅	Identical to lore patch
x1e80100-microsoft-romulus.dtsi	✅	Identical to lore patch
x1e80100-qcp.dts	✅	Identical to lore patch
x1p42100-lenovo-thinkbook-16.dts	✅	Identical to lore patch
x1e80100-honor-magicbook-art-14.dts	❌	MISSING - present in lore patch but absent from PR
x1p42100-microsoft-sp12in.dts	❌	MISSING - present in lore patch but absent from PR

Upstream Patch Status

Commit	Community Verdict
arm64: dts: qcom: hamoa/purwa: Add QREF regulator supplies	✅ ACKed — Reviewed-by: Konrad Dybcio konrad.dybcio@oss.qualcomm.com on 2026-07-15

Dependency Check

• ⚠️ Series dependency noted: This patch is part of a 3-patch series. The cover letter states: "This patch series depends on: https://lore.kernel.org/all/20260713-tcsr_qref_0714-v9-0-373670ab15f9@oss.qualcomm.com/"
• ⚠️ Incomplete series: The PR contains only patch 3/3 (DTS changes). Patches 1/3 (dt-bindings) and 2/3 (driver changes) are not included in this PR.

qcom-next/topics Presence

Commit	Status
FROMLIST: arm64: dts: qcom: hamoa/purwa: Add QREF regulator	⚠️ Not in qcom-next/topics — missing from both qcom-next and kernel-topics branches

Issues

1. Missing files (CRITICAL): The PR is missing 2 of the 19 DTS files that are present in the upstream lore patch 3/3:

   • arch/arm64/boot/dts/qcom/x1e80100-honor-magicbook-art-14.dts
   • arch/arm64/boot/dts/qcom/x1p42100-microsoft-sp12in.dts

   The lore patch adds the same &tcsr { ... } supply block to all 19 X1E80100-family boards, but the PR only includes 17 of them.

2. Incomplete series: This PR contains only patch 3/3 from a 3-patch series. The series includes:

   • Patch 1/3: dt-bindings changes (split x1e80100-tcsr binding from sm8550-tcsr)
   • Patch 2/3: driver changes (migrate tcsrcc-x1e80100.c to clk_ref helper)
   • Patch 3/3: DTS changes (this PR)

   Without patches 1 and 2, the DTS changes in this PR reference supply properties that are not yet documented in the dt-bindings and may not be handled correctly by the driver.

3. Series dependency: The cover letter explicitly states this series depends on another series: https://lore.kernel.org/all/20260713-tcsr_qref_0714-v9-0-373670ab15f9@oss.qualcomm.com/. This dependency should be verified before merging.

Verdict

Do not merge. The PR is incomplete and does not faithfully represent the upstream lore patch. Two board files are missing, and the PR cherry-picks only patch 3/3 from a tightly coupled 3-patch series without including the prerequisite dt-bindings and driver changes.

Recommendation

1. Add the missing files: Include x1e80100-honor-magicbook-art-14.dts and x1p42100-microsoft-sp12in.dts with the same &tcsr supply block as the other boards.

2. Include the full series: Either:

   • Submit patches 1/3 and 2/3 as separate PRs first, then resubmit this PR once those are merged, OR
   • Include all three patches in a single PR to maintain the series integrity.

3. Verify dependency: Confirm that the dependency series (https://lore.kernel.org/all/20260713-tcsr_qref_0714-v9-0-373670ab15f9@oss.qualcomm.com/) has been merged into the target branch before merging this series.

Final Summary

1. Lore link present: Yes — https://lore.kernel.org/linux-arm-msm/20260714-hamoa_tcsr_qref_0714_2-v1-3-13047922a376@oss.qualcomm.com/

2. Lore link matches PR commits: No — PR is missing 2 of 19 DTS files present in lore patch 3/3 (x1e80100-honor-magicbook-art-14.dts and x1p42100-microsoft-sp12in.dts). The 17 files that are present have identical diff content (only context line numbers differ).

3. Upstream patch status: ✅ ACKed — Reviewed-by: Konrad Dybcio on 2026-07-15. Patch is under review and has received maintainer approval. Not yet merged into mainline.

4. PR present in qcom-next/topics: No — commit is missing from both qcom-next and kernel-topics branches per integration_presence_report.md

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 07f50dc44eddcf748a99d1a7523a466438bfffa6
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit	Subject	qcom-next	topics	Final
1/1	[PATCH] FROMLIST: arm64: dts: qcom: hamoa/purwa: Add QREF regulator	missing - no subject, patch-id, or full tree-content match found	missing - no subject, patch-id, or full tree-content match found	missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

[qlijarvis]

PR #1514 — checker-log-analyzer

PR: #1514
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29984078944

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	No style issues
dt-binding-check	⏭️	No binding changes
dtb-check	✅	All DTB validations passed
sparse-check	⏭️	No C/H file changes
check-uapi-headers	⏭️	No UAPI changes
check-patch-compliance	❌	Content mismatch with upstream link
tag-check	✅	Subject has valid FROMLIST: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1514 - FROMLIST: arm64: dts: qcom: hamoa/purwa: Add QREF regulator supplies
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/29984078944

Checker	Result	Summary
checkpatch	✅	No style issues
dt-binding-check	⏭️	No binding changes
dtb-check	✅	All DTB validations passed
sparse-check	⏭️	No C/H file changes
check-uapi-headers	⏭️	No UAPI changes
check-patch-compliance	❌	Content mismatch with upstream link
tag-check	✅	Subject has valid FROMLIST: prefix

❌ check-patch-compliance

Root cause: The patch content in the PR differs from the upstream patch referenced in the Link trailer.

Failure details:

Checking commit: FROMLIST: arm64: dts: qcom: hamoa/purwa: Add QREF regulator supplies
Change is different from the one mentioned in Link

The commit references:

Link: https://lore.kernel.org/linux-arm-msm/20260714-hamoa_tcsr_qref_0714_2-v1-3-13047922a376@oss.qualcomm.com/

Analysis:

This PR modifies 17 DTS/DTSI files to add QREF regulator supplies to the &tcsr node across multiple X1E80100/Hamoa/Purwa boards. The checker detected that the patch content differs from what was posted to the mailing list.

Common causes for content mismatch:

1. Context-only differences — Line numbers shifted due to other changes in the tree (not a real issue)
2. Legitimate adaptations — Changes needed to apply the patch to a different base (should be documented)
3. Missing hunks — Some changes from upstream were omitted
4. Extra hunks — Additional changes not in the upstream patch

Fix:

1. Fetch the upstream patch and compare:

   b4 am --single-message -C -l -3 \
     'https://lore.kernel.org/linux-arm-msm/20260714-hamoa_tcsr_qref_0714_2-v1-3-13047922a376@oss.qualcomm.com/' \
     -o /tmp/upstream
   
   # Compare the actual diff content (ignoring context line shifts)
   git format-patch -1 d80b4f73601fc513cb2fc8b3abdf69eba92d11ef --stdout | \
     awk '/^diff/,/^--$/' | grep -E '^[+-][^+-]' > /tmp/pr-changes.txt
   
   awk '/^diff/,/^--$/' /tmp/upstream/*.mbx | \
     grep -E '^[+-][^+-]' > /tmp/upstream-changes.txt
   
   diff /tmp/pr-changes.txt /tmp/upstream-changes.txt

2. Classify the difference:

   • If only context lines differ → False positive — the checker is sensitive to line number shifts. Document this in the PR description.
   • If the PR has extra files or changes → Either:
     • Split the extra changes into a separate commit, or
     • Update the commit message to note "Additional changes for [reason]" and explain why they differ from upstream
   • If the PR is missing changes from upstream → Add the missing hunks

3. If this is a legitimate adaptation:

   • Consider changing the prefix from FROMLIST: to BACKPORT: if the changes are substantial
   • Add a note in the commit message explaining the adaptation:

     [ Adapted for kernel-topics: added X1E80100 boards not yet in mainline ]
     

Reproduce locally:

cd /path/to/kernel-topics
git fetch origin pull/1514/head:pr1514
git checkout pr1514

# Run the compliance checker
../kernel-checkers/check-patch-compliance.sh \
  --base origin/qcom-next \
  --head pr1514

Verdict

1 blocker to investigate before merge:

The check-patch-compliance failure indicates the patch content differs from the upstream link. This needs investigation to determine if:

• It's a false positive due to context shifts (acceptable)
• It contains legitimate adaptations that should be documented
• It has unintended differences that need correction

All other checkers passed or were correctly skipped. The patch follows proper formatting (checkpatch ✅), has a valid subject prefix (FROMLIST:), and passes DTB validation (dtb-check ✅).

Recommendation: Fetch the upstream patch with b4 am and compare the actual diff content to classify the mismatch. If it's only context differences, document this in the PR. If there are real content differences, either fix them or document why the adaptation is needed.