[CORRUPTED] Synthetic Benchmark PR #1906 - [bench] Add feature to subscription as REST API - #12
Open
amirzaushnizer wants to merge 8 commits into
Open
Conversation
…ept subscriptionId
- Step 1: Update input schema to use subscriptionId (id) instead of subscriptionItemId
- Step 2: Update helper to accept subscriptionId directly
- Step 3: Add OpenAPI metadata and output schema to procedure
- Step 4: Add route config for REST endpoint at POST /subscriptions/{id}/add-feature
- Step 5: Update AddSubscriptionFeatureModal to accept subscriptionId prop
- Step 6: Update form schema to use id instead of subscriptionItemId
- Step 7: Simplify form fields - remove subscription item selector
- Step 8: Update InnerSubscriptionPage to pass subscriptionId to modal
- Update tests to use new input format
- All 42 related tests pass
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
The OpenAPI path is /subscriptions/{id}/add-feature, so we need
routeSuffix: 'add-feature' to match (default would be add-feature-to-subscription).
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR flowglad#1906
Type: Corrupted (contains bugs)
Original PR Title: [bench] Add feature to subscription as REST API
Original PR Description: Reconstructed for skills benchmark from flowglad#1906
Original PR URL: flowglad#1906