[CORRUPTED] Synthetic Benchmark PR #27508 - [bench] Remove unused credential flows in e2e tests and examples - #2
Open
amirzaushnizer wants to merge 12 commits into
Conversation
The staging branch refs were only used to validate CI against an ff_pipeline_host branch with an updated package version. Revert them back to main before checkin to avoid complicating ff_pipeline_host maintenance. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Address PR feedback on the FIC credential flow: - Resolve and validate all required environment variables once at the entry point (createOdspMiddlewares) via resolveOdspEnvironment, and pass the resolved values through to getOdspCredentials and getTestTenantCheckoutClient instead of reaching into process.env deep in the call stack. This fails fast on misconfiguration -- including a missing token__package__import__location, which previously was not detected until the first token request. - Replace the unchecked cast of login__odsp__fic__test__users with a runtime type-check that validates the parsed value is an object with a 'usernames' array of strings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR microsoft#27508
Type: Corrupted (contains bugs)
Original PR Title: [bench] Remove unused credential flows in e2e tests and examples
Original PR Description: Reconstructed for skills benchmark from microsoft#27508
Original PR URL: microsoft#27508