fix(ai): bundle @tauri-apps/plugin-http in the Tauri desktop build (#266) - #272
Merged
Conversation
…ed files Root CLAUDE.md exceeded the large-file warning threshold (50,377 chars). Removes content duplicated from the user-global ~/.claude/CLAUDE.md and the derivable tech-stack line, and moves the per-feature "Current Patterns" subsections into nested CLAUDE.md files that load only when Claude works under that directory (features/plotBoard, services/proForge, services, tests, components, services/copilot, services/voice, services/cloudSync, features/lora). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
) vite.config.ts's rollupOptions.external unconditionally externalized every @tauri-apps/* package from every vite build, including the exact build Tauri's beforeBuildCommand invokes to produce the .deb/.msi. Since services/localServerHttp.ts's @tauri-apps/plugin-http import is dynamic, externalizing it left an unresolvable bare module specifier in the shipped desktop bundle -- confirmed with a real build + real-Chromium repro (TypeError: Failed to resolve module specifier '@tauri-apps/plugin-http'). Every caller's catch classified this identically to a genuinely-down server: no CORS console noise (nothing reached the network layer) and no Ollama/LM Studio discovery, even with both running -- exactly the symptom reported on issue #266 after #269 merged. tauri dev was unaffected (Vite's dev server doesn't apply rollupOptions), so the regression only surfaced in packaged builds, and the existing unit test mocks @tauri-apps/plugin-http via vi.mock, which bypasses real module resolution and structurally cannot catch this class of bug. Fix: extract the existing Tauri-build detection (resolveViteBase.ts's TAURI_ENV_PLATFORM/TAURI_PLATFORM check) into a shared isTauriBuild() export and make rollupOptions.external conditional on it -- the desktop build now bundles @tauri-apps/plugin-http into its own chunk (verified: the real plugin implementation is bundled and referenced via a resolved relative import, not a bare specifier); the web/PWA build is unchanged (those code paths are gated by isTauriRuntime() and never exercised there). Also hardens services/localServerHttp.ts's resolveFetch(): a failed plugin-http import now throws a distinct LocalServerError('plugin_unavailable') and logs it, instead of silently falling through to the generic 'unreachable' classification -- cheap insurance against this exact regression class recurring, undetectable by build-output inspection alone next time. Note: confirmed (via git stash A/B test) that the web build already bundles all @tauri-apps/* packages regardless of this fix -- a pre-existing, unrelated bundle-size issue (not a functional bug, since isTauriRuntime() gates these paths from ever executing in a browser). Out of scope for this fix; left for a separate follow-up. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThe PR fixes packaged Tauri local-server discovery by bundling Tauri HTTP plugins, classifying plugin-load failures distinctly, and returning structured provider connection errors for localized display. It also adds regression tests, changelog and ADR updates, translations, and nested repository guidance. ChangesPackaged local-server discovery
Repository and feature guidance
Estimated code review effort: 3 (Moderate) | ~30 minutes Sequence Diagram(s)sequenceDiagram
participant SettingsUI
participant aiProviderService
participant ollamaService
participant localServerHttp
participant TauriPluginHttp
SettingsUI->>aiProviderService: test provider connection
aiProviderService->>ollamaService: test Ollama connection
ollamaService->>localServerHttp: fetch local server
localServerHttp->>TauriPluginHttp: load desktop HTTP plugin
TauriPluginHttp-->>localServerHttp: return response or import failure
localServerHttp-->>ollamaService: return classified local-server result
ollamaService-->>aiProviderService: return structured error kind
aiProviderService-->>SettingsUI: render localized connection message
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (1)
vite.config.ts (1)
127-133: 🩺 Stability & Availability | 🔵 TrivialRun one packaged desktop smoke test before release.
The conditional Rollup setting is not validated by the helper unit tests, and
tauri devdoes not exercise Rollup output. Verify a real.deb/.msican discover Ollama or LM Studio after packaging.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@vite.config.ts` around lines 127 - 133, Validate the conditional Rollup configuration around external by running a packaged desktop smoke test before release: build a real .deb or .msi, install or launch it, and confirm local Ollama or LM Studio discovery works. Do not rely on helper unit tests or tauri dev as substitutes for packaged output validation.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@config/resolveViteBase.ts`:
- Around line 19-20: Update isTauriBuild in config/resolveViteBase.ts so each
Tauri marker is recognized only when its value is trimmed and non-empty, while
preserving detection for valid values. Add regression cases in
tests/unit/resolveViteBase.test.ts covering empty and whitespace-only
TAURI_ENV_PLATFORM and TAURI_PLATFORM values.
In `@services/CLAUDE.md`:
- Line 13: Update the LanguageTool behavior description in the services
documentation to remove “degrades silently” and specify that network failures
produce sanitized logger output and/or a brief actionable user status. Keep
manuscript text excluded from logs and preserve the existing empty-result
fallback, while documenting the required async failure handling rather than
treating silent swallowing as expected.
In `@services/localServerHttp.ts`:
- Around line 82-85: Update the LocalServerError handling around the plugin load
failure to expose only the stable plugin_unavailable code or translation key at
the service boundary, rather than returning the hard-coded technical message
through ollamaService. Preserve the detailed cause for logging via
services/logger.ts, and ensure the UI translates the exposed code before
rendering user-facing text.
In `@services/voice/CLAUDE.md`:
- Line 5: Clarify the voice logging guidance near HybridIntentEngine and
VoiceCommandService: raw transcripts must never be logged, persisted, or
exposed, including through the IDB log sink. State that only appropriately
redacted event metadata may be stored, or remove the transcript-persistence
reference entirely.
In `@tests/CLAUDE.md`:
- Line 3: Update the useAppSelectorShallow test mock guidance to avoid
introducing any new biome-ignore suppression or explicit any usage. Replace the
untyped selector mock with a typed test helper/mock state that includes
plotBoard and keeps connections, subplots, and tensionOverrides under
project.present.data.
---
Nitpick comments:
In `@vite.config.ts`:
- Around line 127-133: Validate the conditional Rollup configuration around
external by running a packaged desktop smoke test before release: build a real
.deb or .msi, install or launch it, and confirm local Ollama or LM Studio
discovery works. Do not rely on helper unit tests or tauri dev as substitutes
for packaged output validation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: bc3cb309-d08e-49fd-bba3-0dc2ad8d99c6
📒 Files selected for processing (19)
CHANGELOG.mdCLAUDE.mdcomponents/CLAUDE.mdconfig/resolveViteBase.tsdocs/adr/0012-local-server-connectivity-tauri-http.mdfeatures/lora/CLAUDE.mdfeatures/plotBoard/CLAUDE.mdservices/CLAUDE.mdservices/cloudSync/CLAUDE.mdservices/copilot/CLAUDE.mdservices/localServerHttp.tsservices/ollamaService.tsservices/proForge/CLAUDE.mdservices/voice/CLAUDE.mdtests/CLAUDE.mdtests/unit/localServerHttpPluginUnavailable.test.tstests/unit/ollamaService.test.tstests/unit/resolveViteBase.test.tsvite.config.ts
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This was referenced Jul 28, 2026
- config/resolveViteBase.ts: isTauriBuild() now requires a trimmed, non-empty marker value -- an empty-string TAURI_ENV_PLATFORM/ TAURI_PLATFORM (e.g. a CI matrix that sets it to "" to unset it) must not be read as a Tauri build. Regression tests added. - services/CLAUDE.md: corrected LanguageTool's "degrades silently" wording -- the service actually logs via services/logger.ts and returns a distinguishable status, it just never blocks typing. - Localized ALL of testAIConnection's failure paths across every provider (openai/ollama/anthropic/grok/gemini/webllm), not just the new plugin_unavailable branch CodeRabbit flagged: added a stable, i18n-mappable `kind` (+ `params` for interpolation) alongside the existing raw `error` string (kept for logs). AiProviderCard now translates via `settings.ai.testError.<kind>` when present, falling back to the raw string only when absent. New keys added to all 19 locales. Also corrected the ollama desktop-required hard-gate message in aiProviderService.ts, which had drifted back to blaming CSP instead of CORS/Private Network Access (ADR-0012). - services/voice/CLAUDE.md: clarified the transcript-logging guidance, which read ambiguously as if transcripts route into the IDB log sink; the code already never passes transcript text to services/logger.ts. - tests/CLAUDE.md: clarified that the useAppSelectorShallow mock's `any` + biome-ignore documents an existing convention (10 test files already use it), not a new prescription -- noted a shared typed helper as a future refactor candidate rather than doing it here. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Owner
Author
|
@CodeAnt-AI review |
There was a problem hiding this comment.
Actionable comments posted: 8
🧹 Nitpick comments (1)
services/ollamaService.ts (1)
190-192: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse one immediate single-line QNBS-v3 annotation per substantive change.
The changed code either has no QNBS-v3 annotation or uses multi-line annotations. Replace these with one concise, adjacent single-line comment per cohesive change. As per coding guidelines, “For every non-trivial change, add one single-line
QNBS-v3comment explaining why the change exists.”🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@services/ollamaService.ts` around lines 190 - 192, Replace each multi-line or missing annotation with one concise, adjacent single-line QNBS-v3 comment for the substantive change at services/ollamaService.ts:190-192, services/aiProviderService.ts:729-752, components/settings/AiProviderCard.tsx:104-110, tests/unit/ollamaService.test.ts:89-106, tests/unit/aiProviderService.test.ts:239-270, and tests/unit/settings/AiProviderCard.test.tsx:242-244. Ensure each comment explains why that specific behavior or test change exists, without adding multiple annotations for one cohesive change.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@locales/fr/settings.json`:
- Line 252: Correct the French timeout message for settings.ai.testError.timeout
in locales/fr/settings.json to describe the Ollama connection timing out,
preserving the {{url}} placeholder, then regenerate
public/locales/fr/bundle.json so its corresponding translation matches the
corrected source.
In `@locales/hu/settings.json`:
- Around line 252-253: Update settings.ai.testError.timeout and
settings.ai.testError.unreachable in locales/hu/settings.json (252-253),
locales/is/settings.json (252-253), locales/it/settings.json (252-253),
locales/ja/settings.json (252-253), locales/ko/settings.json (252-253),
locales/pt/settings.json (252-253), locales/ru/settings.json (252-253),
locales/sv/settings.json (252-253), and locales/zh/settings.json (252-253) to
use provider-neutral translations while preserving the url and message
placeholders. Regenerate the corresponding entries in
public/locales/ar/bundle.json (1860-1861) and public/locales/de/bundle.json
(1860-1861) from the corrected source translations.
- Line 253: Remove the {{message}} interpolation from the user-facing
settings.ai.testError.unreachable translation in locales/hu/settings.json,
locales/is/settings.json, locales/it/settings.json, locales/ja/settings.json,
locales/ko/settings.json, locales/pt/settings.json, locales/ru/settings.json,
locales/sv/settings.json, and locales/zh/settings.json. Update the
unreachable-error handling in services/logger.ts to log the underlying exception
separately, then regenerate public/locales/ar/bundle.json and
public/locales/de/bundle.json so their corresponding translations no longer
include the interpolation.
In `@public/locales/es/bundle.json`:
- Around line 1860-1861: Update the Spanish translations for
settings.ai.testError.timeout and settings.ai.testError.unreachable to avoid
hard-coding “Ollama”; use provider-neutral wording or the configured
provider-name interpolation while preserving the existing URL and message
placeholders.
In `@public/locales/fi/bundle.json`:
- Line 1861: Update the `settings.ai.testError.unreachable` translation in the
Finnish locale to use the product name `Ollama` instead of `Ollamaa`, preserving
the rest of the message and placeholders.
In `@public/locales/hu/bundle.json`:
- Line 1860: Update the settings.ai.testError.timeout translation in the
Hungarian locale to remove the hardcoded Ollama provider name. Use
provider-neutral wording, or interpolate the actual provider consistently with
the result.kind lookup used by all AI providers.
In `@services/aiProviderService.ts`:
- Around line 874-880: Complete the unexpected error translation contract:
preserve kind: 'unexpected' in services/aiProviderService.ts:874-880, add a
rendered-error regression case in
tests/unit/settings/AiProviderCard.test.tsx:226-246, add
settings.ai.testError.unexpected to the source locale, then regenerate
public/locales/ko/bundle.json:1858-1866,
public/locales/pt/bundle.json:1858-1866,
public/locales/ru/bundle.json:1858-1866,
public/locales/sv/bundle.json:1858-1866, and
public/locales/zh/bundle.json:1858-1866.
In `@services/ollamaService.ts`:
- Around line 196-201: Update the error return in the Ollama request handling
flow to stop exposing the caught exception message through the user-facing error
and i18n params. Keep the raw transport details only in sanitized logger
context, and return an actionable localized failure using safe context such as
resolvedUrl; preserve the existing unreachable kind and failure shape.
---
Nitpick comments:
In `@services/ollamaService.ts`:
- Around line 190-192: Replace each multi-line or missing annotation with one
concise, adjacent single-line QNBS-v3 comment for the substantive change at
services/ollamaService.ts:190-192, services/aiProviderService.ts:729-752,
components/settings/AiProviderCard.tsx:104-110,
tests/unit/ollamaService.test.ts:89-106,
tests/unit/aiProviderService.test.ts:239-270, and
tests/unit/settings/AiProviderCard.test.tsx:242-244. Ensure each comment
explains why that specific behavior or test change exists, without adding
multiple annotations for one cohesive change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4a9a2b04-e989-4edb-873a-d80a405aca9c
📒 Files selected for processing (49)
components/settings/AiProviderCard.tsxconfig/resolveViteBase.tslocales/ar/settings.jsonlocales/de/settings.jsonlocales/el/settings.jsonlocales/en/settings.jsonlocales/es/settings.jsonlocales/eu/settings.jsonlocales/fa/settings.jsonlocales/fi/settings.jsonlocales/fr/settings.jsonlocales/he/settings.jsonlocales/hu/settings.jsonlocales/is/settings.jsonlocales/it/settings.jsonlocales/ja/settings.jsonlocales/ko/settings.jsonlocales/pt/settings.jsonlocales/ru/settings.jsonlocales/sv/settings.jsonlocales/zh/settings.jsonpublic/locales/ar/bundle.jsonpublic/locales/de/bundle.jsonpublic/locales/el/bundle.jsonpublic/locales/en/bundle.jsonpublic/locales/es/bundle.jsonpublic/locales/eu/bundle.jsonpublic/locales/fa/bundle.jsonpublic/locales/fi/bundle.jsonpublic/locales/fr/bundle.jsonpublic/locales/he/bundle.jsonpublic/locales/hu/bundle.jsonpublic/locales/is/bundle.jsonpublic/locales/it/bundle.jsonpublic/locales/ja/bundle.jsonpublic/locales/ko/bundle.jsonpublic/locales/pt/bundle.jsonpublic/locales/ru/bundle.jsonpublic/locales/sv/bundle.jsonpublic/locales/zh/bundle.jsonservices/CLAUDE.mdservices/aiProviderService.tsservices/ollamaService.tsservices/voice/CLAUDE.mdtests/CLAUDE.mdtests/unit/aiProviderService.test.tstests/unit/ollamaService.test.tstests/unit/resolveViteBase.test.tstests/unit/settings/AiProviderCard.test.tsx
🚧 Files skipped from review as they are similar to previous changes (3)
- tests/unit/resolveViteBase.test.ts
- services/CLAUDE.md
- config/resolveViteBase.ts
- Made settings.ai.testError.timeout/unreachable provider-neutral --
these keys are selected by the shared, provider-agnostic result.kind
lookup in AiProviderCard, so hardcoding "Ollama" would misrepresent
a future non-Ollama provider's timeout/unreachable failure as an
Ollama one. Reworded across all 19 locales (also fixes the French
wording that implied Ollama itself had expired, and makes the
Finnish "Ollamaa" partitive-case reference moot since the word is
gone entirely).
- Removed {{message}} interpolation from testError.unreachable and
dropped `params.message` from testOllamaConnection's unreachable
branch and testAIConnection's outer catch (CWE-209: raw transport
exception text -- which can include internal detail -- must never
reach the localized UI string). The technical message is now logged
via services/logger.ts (new loggers in ollamaService.ts and
aiProviderService.ts) instead, preserving it for diagnostics.
- Added the missing settings.ai.testError.unexpected key across all
19 locales -- the catch-all branch already returned kind:
'unexpected', but no translation existed, so the UI rendered the
raw key string on any unforeseen connection-test failure. Added a
regression test in AiProviderCard.test.tsx covering this exact case.
Verified: pnpm run i18n:check (2843 keys x 19 locales, clean),
pnpm run lint (clean), pnpm run typecheck (clean), and the full
AI-provider/ollama/AiProviderCard test suites (103 tests passing).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Owner
Author
|
@CodeAnt-AI review |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/unit/settings/AiProviderCard.test.tsx (1)
249-267: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winMissing
QNBS-v3comment on this new test.The adjacent
httpErrortest carries aQNBS-v3explanatory comment; this newunexpected-failure regression test does not, breaking the established convention for non-trivial changes in this file.✏️ Proposed fix
+ // QNBS-v3: regression test for the "unexpected" failure kind — ensures params-less + // technical error messages never leak past the i18n key into the rendered UI. it('desktop: an unexpected failure (no params) renders the translated key without crashing', async () => {Based on coding guidelines: "Add one-line
QNBS-v3comments explaining why for non-trivial changes; use the language-appropriate comment syntax."🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/unit/settings/AiProviderCard.test.tsx` around lines 249 - 267, Add a one-line QNBS-v3 explanatory comment immediately before the new desktop unexpected-failure test, matching the adjacent httpError test’s convention and using valid TypeScript comment syntax. Keep the test behavior unchanged.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/unit/settings/AiProviderCard.test.tsx`:
- Around line 249-267: Add a one-line QNBS-v3 explanatory comment immediately
before the new desktop unexpected-failure test, matching the adjacent httpError
test’s convention and using valid TypeScript comment syntax. Keep the test
behavior unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: fd7be6e0-565b-4bf7-8b26-1ab9b8053ec2
📒 Files selected for processing (43)
locales/ar/settings.jsonlocales/de/settings.jsonlocales/el/settings.jsonlocales/en/settings.jsonlocales/es/settings.jsonlocales/eu/settings.jsonlocales/fa/settings.jsonlocales/fi/settings.jsonlocales/fr/settings.jsonlocales/he/settings.jsonlocales/hu/settings.jsonlocales/is/settings.jsonlocales/it/settings.jsonlocales/ja/settings.jsonlocales/ko/settings.jsonlocales/pt/settings.jsonlocales/ru/settings.jsonlocales/sv/settings.jsonlocales/zh/settings.jsonpublic/locales/ar/bundle.jsonpublic/locales/de/bundle.jsonpublic/locales/el/bundle.jsonpublic/locales/en/bundle.jsonpublic/locales/es/bundle.jsonpublic/locales/eu/bundle.jsonpublic/locales/fa/bundle.jsonpublic/locales/fi/bundle.jsonpublic/locales/fr/bundle.jsonpublic/locales/he/bundle.jsonpublic/locales/hu/bundle.jsonpublic/locales/is/bundle.jsonpublic/locales/it/bundle.jsonpublic/locales/ja/bundle.jsonpublic/locales/ko/bundle.jsonpublic/locales/pt/bundle.jsonpublic/locales/ru/bundle.jsonpublic/locales/sv/bundle.jsonpublic/locales/zh/bundle.jsonservices/aiProviderService.tsservices/ollamaService.tstests/unit/aiProviderService.test.tstests/unit/ollamaService.test.tstests/unit/settings/AiProviderCard.test.tsx
🚧 Files skipped from review as they are similar to previous changes (38)
- locales/ja/settings.json
- locales/el/settings.json
- locales/fr/settings.json
- locales/eu/settings.json
- locales/fa/settings.json
- locales/es/settings.json
- locales/pt/settings.json
- locales/it/settings.json
- locales/ar/settings.json
- locales/zh/settings.json
- locales/ru/settings.json
- locales/he/settings.json
- locales/fi/settings.json
- locales/is/settings.json
- locales/ko/settings.json
- public/locales/ru/bundle.json
- locales/sv/settings.json
- public/locales/ar/bundle.json
- public/locales/pt/bundle.json
- public/locales/el/bundle.json
- public/locales/fi/bundle.json
- locales/en/settings.json
- public/locales/en/bundle.json
- public/locales/de/bundle.json
- public/locales/zh/bundle.json
- public/locales/fa/bundle.json
- public/locales/fr/bundle.json
- locales/de/settings.json
- public/locales/hu/bundle.json
- public/locales/he/bundle.json
- public/locales/eu/bundle.json
- public/locales/sv/bundle.json
- public/locales/is/bundle.json
- public/locales/ko/bundle.json
- locales/hu/settings.json
- tests/unit/aiProviderService.test.ts
- tests/unit/ollamaService.test.ts
- services/aiProviderService.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the still-open half of #266: after #269 merged, the desktop
.deb/.msibuild stopped discovering a running Ollama/LM Studio even though CORS noise was gone (reported by @gellenburg on the reopened issue).Root cause:
vite.config.ts'srollupOptions.externalunconditionally externalized every@tauri-apps/*package from everyvite build, including the exact build Tauri'sbeforeBuildCommandinvokes to produce the packaged app. Sinceservices/localServerHttp.ts's@tauri-apps/plugin-httpimport is dynamic, this left an unresolvable bare module specifier in the shipped desktop bundle — confirmed with a real build + real-Chromium repro producingTypeError: Failed to resolve module specifier '@tauri-apps/plugin-http'. Every caller's catch classified this identically to a genuinely-down server: no CORS console noise (nothing reached the network layer), and no discovery, even with Ollama/LM Studio running.tauri devwas unaffected (Vite's dev server doesn't applyrollupOptions), so this only surfaced in packaged builds — and the existing unit test mocks@tauri-apps/plugin-httpviavi.mock, which bypasses real module resolution and structurally can't catch this class of bug.Fix
resolveViteBase.ts'sTAURI_ENV_PLATFORM/TAURI_PLATFORMcheck) into a sharedisTauriBuild()export, and maderollupOptions.externalconditional on it. Verified via a simulated Tauri build (TAURI_ENV_PLATFORM=linux pnpm run build) that@tauri-apps/plugin-httpnow bundles into its own real chunk, referenced via a resolved relative import rather than a bare specifier. The web/PWA build is unaffected — those code paths are gated byisTauriRuntime()and never exercised there.services/localServerHttp.ts'sresolveFetch(): a failed plugin import now throws a distinctLocalServerError('plugin_unavailable')(logged), instead of silently folding into the generic'unreachable'classification — so a future regression of this class fails loudly instead of looking like a dead server.Note: this branch's base (local
main) also carries one small unrelated housekeeping commit (chore(docs): trim root CLAUDE.md and migrate feature patterns to nested files) that predates this fix and isn't part of it — flagging for transparency in review.Also discovered, explicitly out of scope for this PR: the web/Vercel build already bundles all
@tauri-apps/*packages regardless of this fix (confirmed via a git-stash A/B test against the unmodified code) — a pre-existing bundle-size issue, not a functional bug, sinceisTauriRuntime()gates those paths from ever executing in a browser. Left for a separate follow-up.Test plan
pnpm run lint— cleanpnpm run typecheck— cleanpnpm exec vitest run tests/unit/resolveViteBase.test.ts tests/unit/localServerHttp.test.ts tests/unit/localServerHttpPluginUnavailable.test.ts tests/unit/ollamaService.test.ts— 40/40 passingTAURI_ENV_PLATFORM=linux pnpm run build) — confirmed@tauri-apps/plugin-httpresolves into a real bundled chunk, no unresolved bare specifiertauri build+ manual Ollama/LM Studio smoke test on the packaged.deb/.msi(not feasible in this environment — flagging for manual verification before merge if possible)🤖 Generated with Claude Code
Summary by CodeRabbit