Update qinstall.sh: store_config(): Change for more efficency, and no…#38
Update qinstall.sh: store_config(): Change for more efficency, and no…#38luca1234567a wants to merge 1 commit into
Conversation
…t necessary operation. Change order of if.
|
Thanks for working on this. I think the intent makes sense, but I would not merge this version as-is for two reasons:
Suggested direction:
So from my side, this PR needs one more revision before it is safe to merge. |
store_config(): Change for more efficency, and not necessary operation. Change order of
if.Prevent non necessary execution of
current_md5sum=$($CMD_MD5SUM "$file" 2>/dev/null | $CMD_CUT -d' ' -f1)if $file non exist.Place first
if [ -z "$orig_md5sum" ]; thenbecause if $orig_md5sum is empty theif [ "$orig_md5sum" = "$current_md5sum" ] || [ "$new_md5sum" = "$current_md5sum" ]; thenallways was false.