add backup_delete info in metadata for delete rpc - #482
Open
sonasingh46 wants to merge 1 commit into
Open
sonasingh46 wants to merge 1 commit into
sonasingh46 wants to merge 1 commit into
Conversation
|
PR Packages Published Python Package:
NPM Package:
|
|
The latest Buf updates on your PR. Results from workflow Pull Request / linting (pull_request).
|
Signed-off-by: Ashutosh Kumar <ashutosh.kumar@qdrant.com>
sonasingh46
force-pushed
the
delete_backup_resp
branch
from
September 3, 2026 11:28
4a3285b to
285e00c
Compare
syndbg
approved these changes
Sep 3, 2026
syndbg
dismissed
github-actions[bot]’s stale review
September 3, 2026 11:51
make generate has been run
Robert-Stam
requested changes
Sep 3, 2026
Contributor
There was a problem hiding this comment.
Can we please align the names: #468
And what about:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
backup_deletedfield from RPC reqest inadditional_context_fieldsforDeleteClusterRPC.The value for
backup_deletedis eithertrueorfalseas defiend in theDeleteClusterRequestschema of the RPC.