Add memory reporting#158
Closed
tellet-q wants to merge 2 commits into
Closed
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds post-indexing memory/disk telemetry sampling from Qdrant’s REST API and surfaces it both in stdout (“--- Memory & disk ---”) and in the JSON output under results.memory, with an opt-out flag.
Changes:
- Introduces
src/memory.rswith REST wire types, fetching (/collections/{c}/memory, best-effort/telemetry), and a human-readable printer. - Extends results JSON schema (
PhaseResults) to include optionalmemory: Option<MemoryReport>. - Adds
--skip-server-statsto disable the REST-only sampling and documents the feature in README/DEVELOPMENT.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/fixtures/collection_memory.json | Adds a real-world /collections/{c}/memory fixture used by parsing tests. |
| src/results.rs | Adds results.memory to the serialized output structure and updates roundtrip tests. |
| src/memory.rs | Implements REST fetching/parsing + pretty-printed memory/disk report and unit tests. |
| src/main.rs | Calls memory sampling after indexing in upload and legacy runs; handles best-effort failures. |
| src/args/mod.rs | Adds the global --skip-server-stats flag. |
| README.md | Documents memory/disk reporting behavior, JSON field, and port mapping. |
| DEVELOPMENT.md | Adds memory.rs to the source map documentation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tellet-q
force-pushed
the
feat/memory-reporting
branch
from
July 16, 2026 08:18
13a555e to
f398de7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample Qdrant's memory/disk telemetry after indexing (REST) and report it under results.memory in --json:
cachedis what the page cache holds of the on-disk bytes vs. the expected a component wants cached to serve queries without hitting disk — the gap shows how cold the cache is. Runs automatically in bfb upload and legacy runs; gated off by the existing --skip-server-stats.