Upgrade spring boot 3->4 and vaadin 24->25 - #1454
Merged
Merged
Conversation
Disables code signing plugin. Needs to be re-enabled when migration is finished.
Replaces the VaadinWebSecurity as it is deprecated.
Replace deprecated Receiver/StreamResource pattern with UploadHandler for Vaadin 24.8+ compatibility.
…tware/data-manager-app into dependencies/upgrade-spring-boot
Avoids Nullpointer
…aces - UploadFileDisplay: single onFilesChanged(List) method with FileEntry record and ValidationStatus enum - UploadContentValidator: validate(String fileName, InputStream) returning Optional<String> - Pre-commit design: single method approach avoids race conditions; validator returns empty Optional on success, error message on failure
…ator Document interface contracts, method semantics, ChangeType enum, FileEntry record fields, ValidationStatus lifecycle, and the caller-closes-stream ownership rule.
This commit removes the validation whithin the upload component. This makes the ContentUploadComponent.java simpler. Also, the ContentUploadComponent.java now supports uploading multiple files. This can be configured by ContentUploadComponent#setMaxFiles. Also, the max file size can be provided using the UploadConfiguration.java or in the application.properties. Negative values remove the constraint.
- Replace UploadWithDisplay with ContentUploadComponent - Add EditSampleUploadDisplayController for validation handling - Reuse SampleUploadDisplay for file display - Remove deprecated onUploadSucceeded method
…tion - Replace getElement().executeJs() with setDrawerOpened() method - Cleaner, type-safe approach using Vaadin's official API
KochTobi
marked this pull request as ready for review
August 5, 2026 08:10
Tried to sort unmodifiable list, now streams, sorts and collects into new sorted list. # Co-authored-by: steffengreiner <steffen.greiner@qbic.uni-tuebingen.de> # Co-authored-by: Sven F. <sven1103@users.noreply.github.com> # Co-authored-by: Shraddha Pawar <Shraddha0903@users.noreply.github.com>
# Co-authored-by: steffengreiner <steffen.greiner@qbic.uni-tuebingen.de> # Co-authored-by: Sven F. <sven1103@users.noreply.github.com> # Co-authored-by: Shraddha Pawar <Shraddha0903@users.noreply.github.com>
# Co-authored-by: steffengreiner <steffen.greiner@qbic.uni-tuebingen.de> # Co-authored-by: Sven F. <sven1103@users.noreply.github.com> # Co-authored-by: Shraddha Pawar <Shraddha0903@users.noreply.github.com>
# Co-authored-by: steffengreiner <steffen.greiner@qbic.uni-tuebingen.de> # Co-authored-by: Sven F. <sven1103@users.noreply.github.com> # Co-authored-by: Shraddha Pawar <Shraddha0903@users.noreply.github.com>
# Co-authored-by: steffengreiner <steffen.greiner@qbic.uni-tuebingen.de> # Co-authored-by: Sven F. <sven1103@users.noreply.github.com> # Co-authored-by: Shraddha Pawar <Shraddha0903@users.noreply.github.com>
This reverts commit 4162222
…tware/data-manager-app into dependencies/upgrade-spring-boot
Co-Authored-By: Biscuit <kochtobi-agent@users.noreply.github.com>
Contributor
Author
|
@sven1103 I addressed the failing CI and the remaining known issues. It would be awesome if you could have a look over the changes. @Steffengreiner As far as I can tell no functionality broke. It would be great to have your opinion as well |
Contributor
|
@KochTobi the build fails atm, if you can have a look at it so the PR is ready for merge |
Contributor
Author
|
Steffengreiner
approved these changes
Aug 10, 2026
Steffengreiner
left a comment
Steffengreiner
left a comment
Contributor
There was a problem hiding this comment.
Well done it didn't break and it survived the smoke test and looks awesome! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrades the project to spring boot 4 and vaadin 25
Changes made
Vaadin upgrade to 25.2.5
Replaced or removed deprecated Vaadin functionality or features. Mainly regarding the Upload and Download of data. Requires upgrade of spring boot from 3 to 4 and introduces Jackson.
@AnonymousAllowedtoDataManagerLayoutandLandingPageLayout— Vaadin 25 enforces stricter access control where views with@AnonymousAllowedcannot be nested inside layouts without it, which was blocking unregistered users from accessing the registration flow, login, password reset, legal notice, and data privacy pagesloginForm.setAction("login")inLoginLayout— required for the LoginForm to POST credentials to Spring Security's form login endpoint. Without it, the form only fires a server-side LoginEvent that does not perform actual authenticationSpring boot upgrade to 4.1.0
Change of dependency naming (see spring migration guide). Upgrade dependencies where possible. Move from Jackson 2 to Jackson 3 and use the new namespace
tools.jacksonwhere applicable.Jackson 3 Migration
@ReadingConverterannotation (absent in Spring Data with Jackson 3)Spring Security 7 Changes
openbis-apifat JAR bundles Jetty 9 classes, which are incompatible with Spring Framework 7'sJettyClientHttpRequestFactorythat expects Jetty 12 API)RestClientwith required OAuth2 message converters (FormHttpMessageConverter,OAuth2AccessTokenResponseHttpMessageConverter) and error handleruser-name-attribute=subto ORCID provider configuration (Spring Security 7 no longer infers this default)Open issues
>after pseudo element selectors e.g.a::before > *