Skip to content

Pywr master compatibility - #10

Open
pmslavin wants to merge 6 commits into
pywr:battery-balancefrom
pmslavin:pywr_master_compat
Open

Pywr master compatibility#10
pmslavin wants to merge 6 commits into
pywr:battery-balancefrom
pmslavin:pywr_master_compat

Conversation

@pmslavin

@pmslavin pmslavin commented Feb 9, 2022

Copy link
Copy Markdown

Changes made in pmslavin/pywr-dcopf.pywr_master_compat introduce compatibility with current Pywr master.

  • Updates node types to support new Pywr loading procedure.
  • Adds test for behaviour of initial_volume_pc arg of Battery node.
  • Miscellaneous layout and node ctor validation changes.

@jetuk

jetuk commented Feb 9, 2022

Copy link
Copy Markdown
Member

Thanks @pmslavin. I'll find time to review this. Reminds me this repo needs to have the CI setup. That might be a bit easier following the new pywr approach with Github Actions.

@jetuk
jetuk self-requested a review February 27, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants