Ignore None dataset timestamps in Scene bounds - #3427
Draft
sapunyangkut wants to merge 1 commit into
Draft
Conversation
Exclude None-valued dataset timestamps before computing Scene start and end bounds so valid dataset or reader times remain usable. AI-assisted by OpenAI Codex; submitted as a Draft for maintainer review.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nonedataset timestamps before calculatingScene.start_timeandScene.end_timeCloses #2883.
Validation
git diff --check, reverse patch validation, and a bounded manual security review passedpathlib_abcis not installed; no dependencies were installed for this submissionChecklist
Scene.start_timecomputation fails for datasets/composites withstart_time=None(and same forend_time) #2883sapunyangkuttoAUTHORS.mdAI assistance disclosure
This change was prepared and tested with OpenAI Codex. It is intentionally opened as a Draft for maintainer review. No automated issue/PR comments or Ready transition will be made.