Add resample force kwarg - #726
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #726 +/- ##
==========================================
+ Coverage 93.66% 93.68% +0.02%
==========================================
Files 89 89
Lines 13707 13715 +8
==========================================
+ Hits 12838 12849 +11
+ Misses 869 866 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
djhoese
left a comment
There was a problem hiding this comment.
Looks good to me. I can't help but think this smells like we're doing something wrong in Satpy's design that this is needed.
djhoese
left a comment
There was a problem hiding this comment.
I was pretty sure when I last reviewed this there was another location I found where this equality/comparison needs to be forced, but now I can't find it. It may have just been that we'll need to keep this in mind when I do further work on the pyresample.future resampler stuff.
This PR adds a
forcekwarg to theresampler.resamplecall. When set toTrue, it bypasses the area equality checks that skip the resampling if the geometries are the same. This is useful e.g. when data has NaN gaps (for example after a parallax correction) and one wants to gapfill it, e.g. with nearest neighbour.geometries_are_the_samecheck #660