fix(references/depth): resize() takes interpolation=, not mode= - #9644
Open
Anai-Guo wants to merge 1 commit into
Open
fix(references/depth): resize() takes interpolation=, not mode=#9644Anai-Guo wants to merge 1 commit into
Anai-Guo wants to merge 1 commit into
Conversation
`make_eval_loader` builds a `--weights` preprocessing closure that calls
`torchvision.transforms.functional.resize` with `mode=`:
disp = resize(disp, (H_t, W_t), mode=InterpolationMode.BILINEAR) * scale_factor
valid_disp_mask = resize(valid_disp_mask, (H_t, W_t), mode=InterpolationMode.NEAREST)
`resize` has no `mode` parameter -- its signature is
`resize(img, size, interpolation=..., max_size=None, antialias=True)` -- so
both calls raise `TypeError: resize() got an unexpected keyword argument
'mode'`. The branch is only reached when the loaded weights' transform
rescales the width (`W_t != W_o`) and the dataset yields numpy disparities,
which is why it has gone unnoticed.
Signed-off-by: Anai-Guo <antai12232931@outlook.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9644
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
references/depth/stereo/train.pybuilds an eval preprocessing closure when--weightsis passed, and that closure callstorchvision.transforms.functional.resizewith amode=keyword:https://github.com/pytorch/vision/blob/main/references/depth/stereo/train.py#L225-L229
resizehas nomodeparameter — the interpolation argument has always been calledinterpolation:So both calls raise
TypeErrorrather than resizing. The branch is guarded byW_t != W_oand by the disparity/mask still being numpy, which is why it has stayed unnoticed: it only fires when the loaded weights' transform actually rescales the width.Reproduction
Fix
Rename the keyword to
interpolationat both call sites. Nothing else changes — the intended interpolation modes (BILINEARfor the disparity,NEARESTfor the validity mask) are preserved.Same snippet after the change:
Both verified against an installed
torchvisionbuild, before and after.🤖 Generated with Claude Code