Skip to content

[RFC] Qualcomm AI Engine Direct - RFCs for Dataset calibration support and LoRA with LLMConfig - #23386

Open
qti-mmadhava wants to merge 1 commit into
pytorch:mainfrom
CodeLinaro:rfc_datasets_lora
Open

qti-mmadhava wants to merge 1 commit into
pytorch:mainfrom
CodeLinaro:rfc_datasets_lora

Conversation

@qti-mmadhava

@qti-mmadhava qti-mmadhava commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

This PR contains two RFCs proposing calibration dataset and LoRA configuration support in LlmConfig.

The RFCs extend the existing calibration options and single adapter config for LoRA with:

  • quantization.calibration_dataset: an HFDatasetConfig for Hugging Face datasets and local files, supporting text, chat, image, and audio inputs.
  • lora_configs and quantization.lora_quantize: named adapters and per-method quantization and calibration settings.
  • backend.qnn.lora: QNN controls for adapter inputs and quantization reuse, limited to freeze_all in v1.

cc @psiddh

@pytorch-bot

pytorch-bot Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23386

Note: Links to docs will display an error until the docs builds have been completed.

❌ 14 Awaiting Approval, 1 New Failure

As of commit 6dd47fb with merge base 0b3d26d (image):

AWAITING APPROVAL - The following workflows need approval before CI can run:

NEW FAILURE - The following job has failed:

  • Cadence Build & Test / Resolve CI docker image / resolve (gh)
    ##[error]Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 3, 2026
@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@qti-mmadhava qti-mmadhava changed the title [RFC] Qualcomm AI Engine Direct - LLMConfig RFCs for Dataset calibration support and LoRA [RFC] Qualcomm AI Engine Direct - RFCs for Dataset calibration support and LoRA with LLMConfig Oct 3, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant