Skip to content

Merge cuda-perf.yml into cuda.yml and add 5% perf regression gate (#23385) - #23385

Open
Gasoonjia wants to merge 1 commit into
mainfrom
export-D123135327
Open

Gasoonjia wants to merge 1 commit into
mainfrom
export-D123135327

Conversation

@Gasoonjia

@Gasoonjia Gasoonjia commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary:

cuda-perf.yml is retired. Its benchmark + upload pipeline now runs inside
cuda.yml's test-model-cuda-e2e cells, reusing each cell's exported
pte/ptd and built runner in place (new helper
.ci/scripts/cuda_benchmark_from_e2e.sh, allowlisted to the 7 perf
models; whisper-medium backfilled into the accuracy matrix).

New jobs:

  • upload-benchmark-results: aggregates cuda-bench-* artifacts to the
    unchanged s3://gha-artifacts/executorch-cuda-perf/ prefix (history
    preserved) + HUD dashboard v3 upload.
  • check-perf-regression: fails the PR when decode or prefill tok/s
    drops >5% vs the median of the last 5 successful main runs (same
    model, quant, GPU, min 3 history points; new
    .ci/scripts/cuda_check_regression.py). Bypass with the
    bypass-perf-regression PR label.

Cleanup: delete cuda-perf.yml, rename trigger_cuda_perf.sh to
trigger_cuda_benchmark.sh (retargeted at cuda.yml dispatch inputs),
drop ciflow/cuda-perf from pytorch-probot.yml, update the
_ci-run-decision.yml caller comment.

Differential Revision: D123135327

@pytorch-bot

pytorch-bot Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23385

Note: Links to docs will display an error until the docs builds have been completed.

❌ 9 New Failures, 1 Pending, 1 Unrelated Failure, 19 Unclassified Failures

As of commit 8214424 with merge base 0b3d26d (image):

NEW FAILURES - The following jobs have failed:

UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 3, 2026
@meta-codesync

meta-codesync Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

@Gasoonjia has exported this pull request. If you are a Meta employee, you can view the originating Diff in D123135327.

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

…3385)

Summary:

cuda-perf.yml is retired. Its benchmark + upload pipeline now runs inside
cuda.yml's test-model-cuda-e2e cells, reusing each cell's exported
pte/ptd and built runner in place (new helper
.ci/scripts/cuda_benchmark_from_e2e.sh, allowlisted to the 7 perf
models; whisper-medium backfilled into the accuracy matrix).

New jobs:
- upload-benchmark-results: aggregates cuda-bench-* artifacts to the
  unchanged s3://gha-artifacts/executorch-cuda-perf/ prefix (history
  preserved) + HUD dashboard v3 upload.
- check-perf-regression: fails the PR when decode or prefill tok/s
  drops >5% vs the median of the last 5 successful main runs (same
  model, quant, GPU, min 3 history points; new
  .ci/scripts/cuda_check_regression.py). Bypass with the
  bypass-perf-regression PR label.

Cleanup: delete cuda-perf.yml, rename trigger_cuda_perf.sh to
trigger_cuda_benchmark.sh (retargeted at cuda.yml dispatch inputs),
drop ciflow/cuda-perf from pytorch-probot.yml, update the
_ci-run-decision.yml caller comment.

Differential Revision: D123135327
@meta-codesync meta-codesync Bot changed the title Merge cuda-perf.yml into cuda.yml and add 5% perf regression gate Merge cuda-perf.yml into cuda.yml and add 5% perf regression gate (#23385) Oct 3, 2026
@meta-codesync
meta-codesync Bot force-pushed the export-D123135327 branch from cb2bbc8 to 8214424 Compare October 3, 2026 01:45
@meta-codesync
meta-codesync Bot had a problem deploying to upload-benchmark-results October 3, 2026 02:53 Failure

This branch had an error being deployed

1 failed and 1 active deployments
upload-benchmark-results — 82144247 Deployed Oct 3, 2026 by meta-codesync[bot] via upload-benchmark-results #20277
cadence — 82144247 Deployed Oct 3, 2026 by meta-codesync[bot] via hifi-op-test / hifi4 #31236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant