Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23381
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c91cd15 with merge base ecf5c39 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Ulterior Motive
Prevent Qualcomm shader-compiler crashes during Vulkan pipeline creation across the ET-VK operator library.
Rationale
What: Route runtime-indexed vector reads through branch-based
safe_idx()helpers and writes throughsafe_set().Why: Adreno 720/740 drivers can null-dereference inside
CreateQGLCProgramwhen specialization constants, push constants, or runtime dimensions index UBO-backed vectors. Mean, buffer softmax, and buffer variance reproduced this failure independently.Details
The shared accessors now live in
common.glslh, making them available to both current and legacy indexing code.BufferMetadatasize, stride, and dimension-order accessors handle all eight dimensions without runtime vector or array indexing. Direct unsafe accesses in reduction, variance, packed NCHW conversion, and buffer padding use the same helpers.Arithmetic, shader interfaces, and tensor layouts remain unchanged.
Authored with Codex.
Differential Revision: D123131865