Conversation
Cadence CI had three PR paths: same-repo PRs on pull_request, meta-exported fork PRs on a labeled pull_request_target, and cadence-fork-pr.yml for fork PRs from existing contributors. The meta-exported path has been failing at checkout and is redundant, since export authors are MEMBER and pass the contributor check. Now every job in build-cadence-runner.yml shares one condition: pushes, nightly, dispatch and same-repo PRs as before, plus fork PRs that touch Cadence paths on pull_request_target (opened, synchronize, reopened) when the author is CONTRIBUTOR or above. Fork PRs therefore show the same six jobs as every other run. The label path and cadence-fork-pr.yml are removed. Fork PRs run their own code, so only the Xtensa jobs hold credentials, the Cadence artifacts role. cpu-build and cpu-test now run with contents: read on every path, so linux_job_v3's role/arc never reaches fork code; their compile is short and sccache still reads anonymously. One Resolve CI docker image job serves every path. It resolves the image inline instead of through the shared _docker-image.yml, which checks out the PR head and is refused for fork code on pull_request_target; there it reads the base branch, so a fork cannot pick its image. _xtensa_build.yml, _xtensa_test.yml and _test_cadence.yml take that image as a required input instead of resolving their own. The Xtensa workflows also take allow-fork-checkout, which opts the checkout in, drops the persisted token, and skips the public runner artifact. The runner comment in the Xtensa workflows blamed the CPU vendor for the vision licence failure. The cause is hostname length: RJ-2025.5 xt-clang derives a wrong licence key once the pod hostname reaches 47 characters, which is any runner label over 18. The comment now says that.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23379
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2e4e785 with merge base a78b4da ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This PR needs a
|
Contributor
|
@aliafzal has imported this pull request. If you are a Meta employee, you can view this in D123116687. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folds Cadence CI's three PR paths into build-cadence-runner.yml with one condition for every job. Fork PRs that touch Cadence paths from a CONTRIBUTOR+ author (Meta exports from personal forks included) now get the same six jobs as branch PRs, on pull_request_target. The meta-exported label path and cadence-fork-pr.yml are removed. Only the Xtensa jobs hold credentials; the CPU jobs run with contents: read on every path. The image is resolved once, from the base branch on fork PRs.
Test plan: actionlint is clean and the job condition was checked against each event type. This PR's pull_request run covers the same-repo path; the fork path gets verified after merge via #23219.