Skip to content

Make test hook setup safe across repeated runs - #23376

Merged
meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
metascroy:export-D123082075
Oct 2, 2026
Merged

meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
metascroy:export-D123082075

Conversation

@metascroy

Copy link
Copy Markdown
Contributor

Summary:
Repeated GTest invocations and the XCTest bridge retain the process-global hook registry, so unconditional test-provider registration fails on subsequent suite setup. Register once per process while retaining the assertion that the initial registration succeeded. Add a regression for repeated setup without changing the production one-provider contract or duplicate-provider rejection coverage.

Leave the disabled Xcode-staging configuration unchanged.

Differential Revision: D123082075

Summary:
Repeated GTest invocations and the XCTest bridge retain the process-global hook registry, so unconditional test-provider registration fails on subsequent suite setup. Register once per process while retaining the assertion that the initial registration succeeded. Add a regression for repeated setup without changing the production one-provider contract or duplicate-provider rejection coverage.

Leave the disabled Xcode-staging configuration unchanged.

Differential Revision: D123082075
@metascroy
metascroy requested a review from shoumikhin as a code owner October 2, 2026 20:05
@pytorch-bot

pytorch-bot Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23376

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 6e64ee2 with merge base 305638c (image):

NEW FAILURES - The following jobs have failed:

  • Cadence Build & Test / hifi-build / Resolve CI docker image / resolve (gh)
    ##[error]Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • Cadence Build & Test / Resolve CI docker image / resolve (gh)
    ##[error]Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • Cadence Build & Test / vision-build / Resolve CI docker image / resolve (gh)
    ##[error]Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 2, 2026
@meta-codesync

meta-codesync Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

@metascroy has exported this pull request. If you are a Meta employee, you can view the originating Diff in D123082075.

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync
meta-codesync Bot merged commit ecf5c39 into pytorch:main Oct 2, 2026
231 of 241 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants