Skip to content

Arm backend: Fix for security bug reported by Metis, CWE-125 - #23363

Open
wwwind wants to merge 3 commits into
pytorch:mainfrom
wwwind:fix_metis_1
Open

wwwind wants to merge 3 commits into
pytorch:mainfrom
wwwind:fix_metis_1

Conversation

@wwwind

@wwwind wwwind commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

The security bug is reported by Metis:
"Table decoder pointers are derived from header-provided offsets before the header is validated, so malformed VGF offsets can point outside the vgf_data buffer."
This is the fix.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

Signed-off-by: Elena Zhelezina <elena.zhelezina@arm.com>
Change-Id: Ia5b201644d2f5426ce9c683fa1fe5cd771bf6fc8
@wwwind
wwwind requested a review from digantdesai as a code owner October 2, 2026 16:45
@pytorch-bot

pytorch-bot Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23363

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 5 Pending

As of commit 369dbac with merge base 5e21c13 (image):

NEW FAILURE - The following job has failed:

  • Cadence Build & Test / Resolve CI docker image / resolve (gh)
    ##[error]Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 2, 2026
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Oct 2, 2026
@wwwind wwwind added the release notes: arm Changes to the ARM backend delegate label Oct 2, 2026
@wwwind wwwind added the help wanted Extra attention is needed label Oct 5, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. help wanted Extra attention is needed module: arm Issues related to arm backend release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants