Skip to content

Speed up mypy regr test in CI#15735

Merged
JelleZijlstra merged 2 commits intopython:mainfrom
JelleZijlstra:faster-regrtest
May 9, 2026
Merged

Speed up mypy regr test in CI#15735
JelleZijlstra merged 2 commits intopython:mainfrom
JelleZijlstra:faster-regrtest

Conversation

@JelleZijlstra
Copy link
Copy Markdown
Member

No description provided.

@AlexWaygood
Copy link
Copy Markdown
Member

Woah, that used to take 5-6 minutes -- how is it taking ~19 minutes on recent CI runs?? What on earth changed to cause that much of a regression?

@AlexWaygood
Copy link
Copy Markdown
Member

I think it's because 29bffca means that we're now using Python 3.15 to run regr_test.py, which means we're installing an uncompiled version of mypy in CI.

@AlexWaygood
Copy link
Copy Markdown
Member

It shouldn't be necessary to actually use Python 3.15 to run the script -- we should be able to run mypy with --python-version=3.15 inside the script without mypy being actually run with 3.15.

@JelleZijlstra
Copy link
Copy Markdown
Member Author

Ah good point. Yeah this didn't actually help much, it seemed to help locally.

@JelleZijlstra
Copy link
Copy Markdown
Member Author

Switched it back to 3.14 and now it takes 5 min again. Kept a bugfix Codex found where we were missing environment setup failures because we weren't awaiting some futures.

@JelleZijlstra JelleZijlstra merged commit 40787ee into python:main May 9, 2026
59 checks passed
@JelleZijlstra JelleZijlstra deleted the faster-regrtest branch May 9, 2026 00:27
@AlexWaygood
Copy link
Copy Markdown
Member

we weren't awaiting some futures

Hum, but these aren't async futures, so I don't think they need to be awaited -- what was codex's full reasoning here, OOI?

@hauntsaninja
Copy link
Copy Markdown
Collaborator

The exception will never propagate if you don't .result() it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants