Reject non-finite radius in BoxBlur - #9906
Open
JonnasFigueiredo wants to merge 1 commit into
Open
Conversation
BoxBlur only checked `radius < 0`, so a NaN or infinite radius passed the Python-level validation (`nan < 0` is False) and reached the C `box_blur`, causing a heap-buffer-overflow. Validate that the radius is a finite, non-negative number and raise ValueError, as is already done for negative radii.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9900. Alternative to #9902
BoxBlurvalidatesradius >= 0in Python, butnan < 0(andinf < 0) isFalse, so a non-finite radius slipped through the check and reached the Cbox_blur, causing a heap-buffer-overflow (found by fuzzing).This extends the existing radius validation to reject non-finite values, raising
ValueErrorjust like a negative radius does:Added tests for
nan/inf, both as a scalar and per-axis. I verified against the compiled extension that valid radii still work and thatnan/inf/negative radii are rejected.