Add _normalize_coords() to reduce duplicate code - #9899
Open
radarhere wants to merge 1 commit into
Open
Conversation
Co-authored-by: Krishna Chaitanya Balusu <krishnabkc15@gmail.com>
akx
reviewed
Aug 25, 2026
| ellipse_xy = (xy[0] - radius, xy[1] - radius, xy[0] + radius, xy[1] + radius) | ||
| self.ellipse(ellipse_xy, fill, outline, width) | ||
|
|
||
| def _normalize_coords(self, xy: Coords) -> Sequence[Sequence[float]]: |
Contributor
There was a problem hiding this comment.
This should maybe be a free function in the module?
Member
Author
There was a problem hiding this comment.
Why? It's not used anywhere else.
Contributor
There was a problem hiding this comment.
Since it doesn't need to be overridden by any subclass of ImageDraw I can conceive of, and free functions are a tiny bit faster to call:
In the disassembly for a quick timing example,
- a free function call is
LOAD_GLOBAL(looks at the module globals table) +LOAD_FAST_BORROWfor the argument +CALL - an instance function call is
LOAD_FAST_BORROWfor the localself+LOAD_ATTR(a dict lookup on the instance) +LOAD_FAST_BORROWfor the argument +CALL
So in other words, because it's unnecessary to be an instance method.
Member
Author
There was a problem hiding this comment.
My personal preference would be for code that is only called from internal methods in the instance to be a method, as an indicator of how it is used. It also places it much closer to the first self._normalize_coords(xy), making it quicker to understand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracting a cleanup idea from #9490