Raise ValueError if FPX tile size is not 64px by 64px#9660
Merged
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
hugovk
approved these changes
Jun 28, 2026
| xtile, ytile = i32(s, 16), i32(s, 20) | ||
| if xtile != 64 or ytile != 64: | ||
| msg = "Tile must be 64 pixels by 64 pixels" | ||
| raise ValueError(msg) |
Member
There was a problem hiding this comment.
ValueError seems the right choice, although we're already raising OSError for other things which should probably be ValueError (if we were writing from scratch).
Maybe use OSError here for consistency? Or ValueError for any new ones? I don't mind too much either way.
Member
Author
There was a problem hiding this comment.
Could go either way. I'm more inclined towards what is theoretically correct.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Page 52 (or 42 if you're looking at the printed numbers) of https://graphcomp.com/info/specs/livepicture/fpx.pdf states that