Repository navigation
Fix ImagePath coordinate conversion errors - #10287
Open
shivanshjain456 wants to merge 12 commits into
Open
shivanshjain456 wants to merge 12 commits into
shivanshjain456 wants to merge 12 commits into
Conversation
Member
|
I don't think there's any need to start accepting |
radarhere
reviewed
Oct 23, 2026
| def test_line_invalid_coordinate_conversion() -> None: | ||
| draw = ImageDraw.Draw(Image.new("RGB", (4, 4))) | ||
| with pytest.raises(ValueError, match="cannot convert signaling NaN to float"): | ||
| with pytest.raises(ValueError, match="(?i)cannot convert signaling NaN to float"): |
Author
There was a problem hiding this comment.
I added (?i) after CI showed this Decimal error with an uppercase C on PyPy 3.12 and Python 3.15. Since only the initial letter differed, I’ve narrowed the matcher to [Cc] and applied it to the nested list case too.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10284
Changes proposed in this pull request:
ImagePath.Pathitem assignment tuple-only, while converting unsupported non-tuple input into a normalTypeErrorrather than leakingSystemError.longorfloat.Local validation: editable build succeeded; focused
test_imagepath.pyandtest_imagedraw.pytests passed (302 passed, 1 xfailed); Mypy passed on 303 source files; pre-commit checks passed for both changed test files.AI disclosure: AI was used for issue research, the initial implementation, regression-test development, local validation, and drafting this description. Maintainer feedback led to retaining tuple-only assignment; the updated behavior and tests were reviewed and validated after that change.