Fix parsing noon and midnight with AM/PM - #1338
Open
Yananix wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_time currently interprets "12:30 AM" as 12:30 and raises ValueError for "12:30 PM" because it adds 12 to an hour that is already 12. This also breaks parsing the strings produced by format_time for midnight and noon in en_US.
Normalize hour 12 to zero when an AM/PM marker is present and the format includes a period, then apply the existing PM offset. Inputs without a period keep their existing interpretation.
Tests cover all 24 hours round-tripping through both the default medium format and an explicit h:mm:ss a pattern, uppercase/lowercase AM/PM at noon and midnight, hour-only input, and 12:30 without a marker.
Validation on macOS with Python 3.12.13 and the repository's CLDR 48.2 data: